muleunit: add missing override keyword on OnRun and OnUnhandledException (#663) - #664
Merged
mrjimenez merged 1 commit intoMay 20, 2026
Conversation
Both methods in UnitTestApp override virtuals on wxAppConsole / wxApp (wx/app.h:103 and :303). Clang -Winconsistent-missing-override fires because the sibling OnInit in the same class already has override. Same pattern as amule-project#625 (ServerSocket.h / ClientTCPSocket.h cleanup): just add override to the two declarations. Reported by @Stoatwblr in amule-project#663.
mrjimenez
pushed a commit
to mrjimenez/amule
that referenced
this pull request
Jul 28, 2026
amule-project#664) The macOS Navigate menu renders its accelerators with the native Option glyph automatically, but toolbar tooltips are plain text, so they still read "(Alt+N)". Build a platform-conditional suffix from the U+2325 codepoint rather than a raw literal, so it cannot be mangled by a narrow-to-wide conversion through a non-UTF-8 system encoding (macOS reports Mac OS Roman). Kept outside _() so no translated msgids change. Follow-up to amule-project#642.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #663.
UnitTestAppinunittests/muleunit/main.cppoverrides three virtuals onwxAppConsole/wxApp:OnInit,OnRun, andOnUnhandledException. OnlyOnInithad theoverridekeyword on its declaration, so on clang's-Winconsistent-missing-override(default for any sibling havingoverride) the other two trigger:Two-character fix: add
overrideto both decls.Same pattern as #625 (
ServerSocket.h/ClientTCPSocket.hcleanup). The other warning @Stoatwblr saw in the same compile (libayatana-appindicator deprecation) is the documented known/deferred one — see #628.Reported by @Stoatwblr.