dialog: prompt for nodes.dat on first run alongside server.met - #558
Merged
mrjimenez merged 2 commits intoMay 11, 2026
Merged
Conversation
…amule-project#253) The first-run dialog covered server.met but skipped nodes.dat, leaving Kad disconnected on a fresh install. Replace the yes/no prompt with a single multi-choice dialog that lists every missing bootstrap file (server.met when ED2K is enabled and the server list is empty; nodes.dat when Kad is enabled and the file is missing on disk), defaults to all-selected, and reuses the existing /eMule/Ed2kServersUrl and /eMule/KadNodesUrl prefs. Daemon path (no GUI) downloads each missing file unconditionally, matching the original silent-fetch behaviour for server.met.
Picks up the four new strings (multi-choice dialog title, message, and the two file-name labels). Mechanical line-number churn from the amule.cpp insertion cascades through every source file's references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #253. On a fresh install with Kad enabled, aMule asks the user to download
server.metbut never offersnodes.dat, so Kad sits at "no contacts" until the user manually pastes a URL into the Kad dialog.Fix
Replace the yes/no
wxMessageBoxwith awxMultiChoiceDialog:/eMule/Ed2kServersUrland/eMule/KadNodesUrlprefs (defaulthttp://upd.emule-security.org/{server.met,nodes.dat});Translations regenerated via
scripts/update-po.shto pick up the four new strings; the per-file diff is dominated by mechanical#: src/amule.cpp:NNNline-shift churn.