README: add binary-install path + bandwidth-limit setup note - #527
Merged
Conversation
got3nks
force-pushed
the
pr-readme-binary-install
branch
5 times, most recently
from
May 6, 2026 07:53
bf00dc0 to
dcc244f
Compare
3 tasks
got3nks
force-pushed
the
pr-readme-binary-install
branch
3 times, most recently
from
May 7, 2026 09:21
f3a62ba to
dcc3c86
Compare
got3nks
force-pushed
the
pr-readme-binary-install
branch
2 times, most recently
from
May 28, 2026 07:29
e34a3ec to
75ac254
Compare
Three README changes for users coming to aMule for the first time: 1. Top-level README: restructure "Compiling" -> "Installation" with two options — pre-built binaries (recommended for most users) and building from source (existing flow). Each lists minimum commands and links to its own deep-dive doc. 2. Top-level README: surface the unlimited-bandwidth defaults in the "Setting Up" section. aMule ships with MaxUpload=0 / MaxDownload=0, both interpreted as literal unlimited since the throttler rewrites in 3.0.0. On a residential line that means saturating the link and starving every other application; recommend setting limits to ~80% of line speed with a concrete 100/20 Mbps fibre example. 3. INSTALL_BINARIES.md: new "Running the headless tools" section covering how to invoke amuled / amulecmd / amulegui / amuleweb from a Windows .zip, macOS .dmg, Linux AppImage, or Linux Flatpak — paths and dispatch patterns differ between formats, and the wiki/setup commands previously assumed PATH (i.e. `make install`). Added a Contents TOC for navigation; linked the four per-format sub-headings from docs/README.md so the User Guide stays a thin pointer rather than duplicating the package-format detail.
got3nks
force-pushed
the
pr-readme-binary-install
branch
from
June 3, 2026 14:03
75ac254 to
3ebaa46
Compare
ngosang
pushed a commit
to amule-org/amule-org.github.io
that referenced
this pull request
Jun 3, 2026
…DME (#94) The Connection Speed section's recommendation and math examples were outdated: - Recommended setting only the upload cap ("You don't need to set a maximum download speed") while aMule actually ships with MaxUpload=0 AND MaxDownload=0 (literal-unlimited since the throttler rewrites in 3.0.0). On a connection aMule can saturate, the unlimited-download default starves every other application on the link. - Math example used an old 1024 kb/s / 512 kb/s ADSL profile and the "divide by 8 to get kB/s from kb/s" formulation. Modern fibre is the more realistic baseline, and ISP marketing is almost always in Mbps (not kb/s) today. Align with the README's "Set bandwidth limits" subsection (PR amule-project/amule#527): - Surface the unlimited defaults explicitly, with the link-starvation rationale plus the TCP-ACK angle for uncapped uploads. - Recommend setting both upload and download to ~80% of line speed. - Replace the kb/s ÷ 8 math with Mbps × 125, and the example with a 100/20 Mbps fibre line.
…lease-asset names Audited the placeholder names in this doc against the artifact filenames produced by the Packaging workflow on a clean upstream master tip (run 26888630567). Three of five didn't match: - AppImage: `aMule-<version>-<arch>.AppImage` -> the actual file ships with a `Linux-` infix: `aMule-<version>-Linux-<arch>.AppImage`. Updated the download instruction + the `chmod +x` / `./` invocation glob + the symlink-tutorial example. - Flatpak: same `Linux-` infix missing -> updated to `aMule-<version>-Linux-<arch>.flatpak`. - Windows installer: `aMule-<version>-Setup-<arch>.exe` -> the actual filename has a `Windows-` infix before `Setup`: `aMule-<version>-Windows-Setup-<arch>.exe`. Updated the download instruction + the certutil checksum command. Also nudged the placeholder arch values from `x86_64` / `aarch64` (the uname spelling) to `x64` / `arm64` (the spelling used in the release-asset filenames). The AppRun symlink dispatcher tolerates both spellings -- documented that explicitly alongside the symlink examples so users who follow muscle memory from earlier docs aren't misled. macOS Universal2 `.dmg` and Windows portable `.zip` already matched.
Contributor
Author
|
@mrjimenez after 3.0.0 is released, we'll have to verify the filenames match what's documented in |
got3nks
pushed a commit
to got3nks/amule
that referenced
this pull request
Jul 21, 2026
…ect#527) * fix(amuleweb): restart Asio service before worker startup The synchronous EC connection can leave the process-global io_context in the stopped state before amuleweb creates its HTTP server. Worker threads then return from run() immediately, leaving port 4711 listening but never accepting requests. Restart the io_context before launching the long-lived worker pool so queued HTTP accepts are processed. * docs(asio): correct synchronous EC restart comment --------- Co-authored-by: Gerald B Cox <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aMule 3.0.0 ships pre-built binaries for every desktop, but the README still routes new users straight to the source-build instructions. Most users want a download, not a CMake invocation.
This PR restructures the README's installation flow into two clearly-marked options and adds a binary-install deep-dive doc, plus links the User Guide at
docs/README.mdto the matching binary-install sections so the headless-tools setup commands are accessible no matter which package format the reader installed.What's in the README
The old
## Compilingsection becomes## Installationwith two sub-sections:docs/INSTALL.md.The
## Setting Upsection gains a second numbered step covering bandwidth limits — aMule ships withMaxUpload=0andMaxDownload=0(both interpreted as literal unlimited since #461 / #491), which is the right default for benchmarking but hostile on a residential line. Recommend ~80 % of line speed with a concrete 100/20 Mbps fibre example. The same advice already exists indocs/README.md; this just surfaces it on the front page where new users actually look.What's in
docs/INSTALL_BINARIES.md(new)A
## ContentsTOC at the top with anchored links into every section so the doc is navigable as a reference.Per-platform install walkthroughs with the common pitfalls:
libfuse2t64/libfuse2/fuse/fuse2per distro)--filesystem=homeis in the manifest, so state lives in~/.aMule/exactly like a native install (existing config picked up automatically)xattr -d com.apple.quarantineworks on every version.sha256sum/shasum -a 256/certutil)A new
## Running the headless toolssection covers how to invokeamuled/amulecmd/amulegui/amulewebfrom each binary package — the wiki / User-Guide setup commands assume$PATH(true formake install, false for any binary package), and the path / dispatch pattern differs between formats:.\amuled.exe,.\amulecmd.exe, … all sit alongside in the unzipped folder/Applications/aMule.app/Contents/MacOS/amuled(and friends);amuleguiis the separateaMuleGUI.appbundle. Optional/usr/local/binsymlinks for short names.ln -s aMule-*.AppImage amuled && ./amuled …(already implemented inpackaging/linux/appimage/AppRun)flatpak run --command=amuled org.amule.aMule …What's in
docs/README.md(User Guide)INSTALL_BINARIES.md(binaries) andINSTALL.md(source); previously only the source-build doc was referenced.$PATHassumption and four bullet links to the per-format anchors inINSTALL_BINARIES.md. The package-format detail lives only inINSTALL_BINARIES.mdso the User Guide stays a thin pointer.Verification
MaxUpload/MaxDownloaddefaults of 0 verified atsrc/Preferences.cpp:1020-1021--filesystem=homegrant verified atpackaging/linux/flatpak/org.amule.aMule.yaml.inpackaging/linux/appimage/AppRun:38-45Contents/MacOS/,aMuleGUI.appshipped separately) verified atpackaging/macos/build.sh:103-119,14626888630567on master tiped15edb43; placeholder names inINSTALL_BINARIES.mdaligned in60aafb09eto match the actual artifact names produced by the workflow. The final spot-check against the real 3.0.0 release draft is still pending (see Test plan).Test plan
docs/INSTALL.md, the wiki HighID/Firewall pages already on the live wiki, the Releases page)INSTALL_BINARIES.md#…anchors resolve fromdocs/README.mdon the rendered fork branchINSTALL_BINARIES.md. Master-tip preview against Packaging run26888630567informed the alignment in60aafb09e, but the final check happens on the real release artifacts:aMule-3.0.0-Linux-x64.AppImageaMule-3.0.0-Linux-arm64.AppImageaMule-3.0.0-Linux-x64.flatpakaMule-3.0.0-Linux-arm64.flatpakaMule-3.0.0-macOS-universal2.dmgaMule-3.0.0-Windows-x64.zipaMule-3.0.0-Windows-arm64.zipaMule-3.0.0-Windows-Setup-x64.exeaMule-3.0.0-Windows-Setup-arm64.exe