po: complete update-po refresh and Italian translations - #519
Merged
mrjimenez merged 2 commits intoMay 3, 2026
Conversation
got3nks
force-pushed
the
pr-it-translations-may2026
branch
from
May 3, 2026 08:29
7ac55e2 to
ee1e756
Compare
Re-run scripts/update-po.sh to refresh po/amule.pot and merge into all po/*.po files. The previous update-po run did not pick up the new strings introduced in src/AppImageIntegration.cpp (PR amule-project#510), because src/AppImageIntegration.cpp had not yet been added to po/POTFILES.in when xgettext ran. This commit propagates the missing 14 user-facing strings into amule.pot and into every locale's .po file (as untranslated or fuzzy-matched entries, per msgmerge). Also fix scripts/update-po.sh to preserve aMule package metadata in the regenerated pot: - Pass --copyright-holder, --package-name, --package-version, and --msgid-bugs-address to xgettext so the pot header retains 'Project-Id-Version: aMule SVN' and the upstream bug address. - Substitute the current year for xgettext's 'Copyright (C) YEAR' placeholder using sed. Without these, every regen reset the pot header to xgettext placeholders (PACKAGE VERSION, THE PACKAGE'S COPYRIGHT HOLDER, YEAR), erasing the aMule-specific package references.
Translate the 8 untranslated entries and review the 26 fuzzy entries in po/it.po that were introduced by the previous translation refresh (msgmerge against the regenerated po/amule.pot). Untranslated entries now translated: - Connection timed out diagnostic - EC_TAG_FRIEND_SHARED requires EC_TAG_FRIEND or EC_TAG_CLIENT - HTTP empty response body / 401 Unauthorized errors - GeoLite2 missing-URL hint - Kad search reask widening (long descriptive tooltip + 2 status messages) Fuzzy entries un-fuzzied where msgmerge's similarity match was already correct (typo recovery for existant/successfully/periodically; ipfilter.dat / external-connections / out-of-disk-space wording). Fuzzy entries replaced where msgmerge guessed wrongly: - Friend/Client not found mapped to 'File non trovato' - HTTP error messages collapsed onto unrelated translations - MuleTrayIcon connected-state strings lost their (HighID/LowID/firewalled) qualifier - Server / Server IP strings swapped meanings
got3nks
force-pushed
the
pr-it-translations-may2026
branch
from
May 3, 2026 08:33
ee1e756 to
ee13065
Compare
got3nks
added a commit
to got3nks/amule
that referenced
this pull request
Jul 18, 2026
…mule-project#519) The read-only chat relay (amule-project#517) split ProcessChatMessage into a daemon definition and a GUI definition under #ifdef AMULE_DAEMON, duplicating the message-filter entry and the log + IncMessagesReceived + Notify_ChatProcessMsg tail across both. Collapse to a single definition and guard only the parts that are genuinely GUI-only — the advanced spam filter (captcha challenge + URL heuristic), which depends on CCaptchaGenerator (compiled only into the monolithic target, pulls wxImage) and touches the chat window. On the daemon that block compiles out and the function falls through to the shared notify tail: identical behaviour, one copy of the shared logic. The captcha stubs for the daemon stay as-is. No functional change. Built amuled + amule (monolithic) + amulegui.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR has two commits:
Re-run
scripts/update-po.sh+ fix metadata loss in script. The previous run (commitb17c33c28) did not pick up the strings introduced insrc/AppImageIntegration.cpp(PR packaging: AppImage/Flatpak/macOS/Windows + first-run launcher prompt #510), becausesrc/AppImageIntegration.cpphad not yet been added topo/POTFILES.inwhen xgettext ran. This commit propagates the missing 14 user-facing strings intoamule.potand into every locale's.po. Additionally,scripts/update-po.shis updated so future runs preserve the aMule-specific pot header:--copyright-holder,--package-name,--package-version,--msgid-bugs-addressto xgettext so the header retainsProject-Id-Version: aMule SVN, the upstream bug address, and the FSF copyright holder.sedstep that substitutes the current year for xgettext'sCopyright (C) YEARplaceholder.Without these, every regen would reset the pot header back to xgettext placeholders (
PACKAGE VERSION,THE PACKAGE'S COPYRIGHT HOLDER,YEAR), erasing the aMule-specific package references.Italian (
po/it.po): 34 entries addressed — 8 newly translated, 17 fuzzy translations replaced (msgmerge had collapsed several msgids onto unrelated existing translations, e.g.Friend not found.→File non trovato., HTTP error strings onto random shared-files messages), 9 fuzzy entries un-fuzzied where the existing translation was still correct (typo recovery:existant→existent,succesfully→successfully,periodicaly→periodically).After this PR,
msgfmt --check po/it.poreports 1650 translated messages, 0 fuzzy, 0 untranslated.Why two commits?
The pot/po refresh + script fix touches all 38 locales (~3000 lines of insertions; mostly the 14 AppImage strings being injected into each
.po, plus the metadata-flag and year-substitution additions toscripts/update-po.sh). The Italian translation work is a separate concern that only touchespo/it.po. Splitting makes the second commit reviewable as pure translation work.Test plan
msgfmt --check --statistics po/it.po— 1650 translated, 0 fuzzy, 0 untranslatedbash scripts/update-po.shis a no-op when run on top of this branch (idempotent — pot is now in sync with source)po/amule.pot(`grep -c AppImage po/amule.pot` returns 18, was 0)