po: localize AppImage integration prompt + Italian translation - #518
Merged
mrjimenez merged 2 commits intoMay 3, 2026
Merged
Conversation
PR amule-project#510 (AppImage first-run launcher prompt) added 14 user-facing strings in src/AppImageIntegration.cpp wrapped with _() / wxTRANSLATE for translation. The file itself was never added to po/POTFILES.in, so xgettext skips it during the periodic 'Automated translation update' run — the strings are extractable in source but invisible to the translation pipeline. Result: the new dialog stays English-only in every locale, even after translators sync their .po files. Add src/AppImageIntegration.cpp to po/POTFILES.in (alphabetised under src/A*). The next automated translation update will then regenerate po/aMule.pot with the new entries, propagating them to translators through the existing workflow.
This was referenced May 27, 2026
mrjimenez
pushed a commit
that referenced
this pull request
May 27, 2026
The 3.0.0 entry only documented the initial 91 PRs through #518. 136 follow-up PRs have landed since 2026-05-05 and most of them belong to clearly identified themes (EC big-library performance, AICH / SharedFileList algorithmic fixes, the shared-folder watcher, the NSIS / .dmg / autostart packaging additions, crash diagnostics, the SVN -> GIT rename, translation gap-fills, …). Expand each existing 3.0.0 section in place with the relevant follow-up bullets, update the contributor counts (98 -> 234 total PRs; got3nks 57 -> 182, mrjimenez 12 -> 17, danim7 promoted to a named entry, cardpuncher added), and add a "Merged PRs in this release" appendix listing every PR number for traceability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #510 introduced the AppImage first-run desktop-integration prompt in
src/AppImageIntegration.cppwith all user-facing strings wrapped in_(), but the file was never added topo/POTFILES.in. As a result xgettext never extracted the new strings, so translators had no way to see them.This PR has two commits:
po: add src/AppImageIntegration.cpp to POTFILES.in— one-line addition so the 14 translatable strings get picked up by the nextmake update-po.po: add Italian translations for AppImage integration prompt— Italian (it.po) translations for all 14 new strings, since I'm Italian-speaking and could provide them right away. Other locales remain unchanged and will pick up the new msgids on the next translation refresh.msgfmt --check po/it.popasses (1637 translated messages, no errors).Test plan
msgfmt --check --statistics -o /dev/null po/it.po— cleanxgettextofAppImageIntegration.cppare present init.powith no duplicate msgids#, c-formatflags preserved on the two%s-bearing strings