amulegui: clean startup on Cancel + watchdog on wrong connection data - #465

Summary

Two small fixes in src/amule-remote-gui.cpp that both address problems the user hits on the very first screen of amulegui — the EC connection dialog.

1. Cancel leaves threads running. Clicking Cancel on the initial connection dialog printed 4 threads were not terminated by the application on exit. OnInit() returned false without tearing down the Asio service, the core poll timer and the remote-connect socket it had already created, and because the main loop never ran, wx never called ShutDown() / OnExit().

2. Wrong host / unreachable daemon hangs the app. Entering an incorrect host or a host where amuled isn't listening, then clicking OK, left amulegui in the "not responding" state (the OS offers to force-close it) for several minutes while the TCP SYN silently timed out. The main loop was running, but no window had yet been shown, so the user had no visible signal that anything was happening.

3 files changed, 67 insertions(+), 1 deletion(-). No behaviour change for the happy path.

Fix 1 — unwind partial init on Cancel

On the cancel path out of ShowConnectionDialog(), explicitly stop m_AsioService, destroy the CRemoteConnect socket, and delete poll_timer. Mirror of what ShutDown() does — necessary because OnInit() returning false skips the main loop entirely, so wx never runs its normal teardown.

Fix 2 — watchdog on the EC connect

amulegui constructs CRemoteConnect with this as the wxEvtHandler* notifier, which selects the async flavour of the connect: ConnectToCore() returns true as soon as the underlying connect() has been dispatched, and OnECConnection is delivered later via AddPendingEvent() once the socket resolves one way or the other. For an unreachable host, the socket layer keeps retrying the SYN for minutes before giving up, during which the user sees a frozen app with no visible window.

A 15 s one-shot wxTimer (ID_REMOTE_CONNECT_TIMEOUT_TIMER) is started right after ShowConnectionDialog() returns true. If it fires before OnECConnection:

• a wxMessageBox explains the timeout and names the host:port the user typed;
• ShutDown() tears everything down;
• ExitMainLoop() returns control to wx.

The watchdog is cancelled at the top of OnECConnection (success and failure paths), and also as a safety net in ShutDown().

Files touched

 src/amule-remote-gui.cpp      | 58 ++++++++++++++++++++++++++++++-
 src/amule-remote-gui.h        |  7 ++++
 src/include/common/EventIDs.h |  3 +-

EventIDs.h only adds the new ID_REMOTE_CONNECT_TIMEOUT_TIMER enum value at the end of the existing timer-event block.

Risk

Scoped strictly to amulegui. The core (amule / amuled) is not touched. Happy-path connects are unaffected: on success the watchdog fires its own cancel in OnECConnection before the 15 s elapses.