Puleglot libupnp 1.18 - #448
Merged
Merged
Conversation
got3nks
added a commit
to got3nks/amule
that referenced
this pull request
Jul 11, 2026
…mule-project#448) 17-shared-priority-patch renamed the first shared file to a fixed "renamed-by-test.dat" and never restored the original name. Against the persistent daemon the suite targets, that (a) clobbered a real shared file and (b) made the next run fail: renaming a file to its existing name is a no-op amuled rejects with non-200, so the second run's "PATCH name (rename) -> 200" bounced. Capture the original name alongside the saved priority, rename to a name guaranteed different from it (verifying the change lands with an immediate GET), run the traversal/empty-name negative checks, then restore the original name. jq builds the request body so odd characters in a real filename are escaped. The file is now left exactly as found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #431
Closes #432