Skip to content

Puleglot libupnp 1.18 - #448

Merged
mrjimenez merged 5 commits into
amule-project:masterfrom
mrjimenez:puleglot-libupnp-1.18
Apr 15, 2026
Merged

Puleglot libupnp 1.18#448
mrjimenez merged 5 commits into
amule-project:masterfrom
mrjimenez:puleglot-libupnp-1.18

Conversation

@mrjimenez

Copy link
Copy Markdown
Contributor

Fixes #431
Closes #432

@mrjimenez
mrjimenez merged commit 980f2c8 into amule-project:master Apr 15, 2026
2 checks passed
@mrjimenez
mrjimenez deleted the puleglot-libupnp-1.18 branch April 15, 2026 21:05
got3nks added a commit to got3nks/amule that referenced this pull request Jul 11, 2026
…mule-project#448)

17-shared-priority-patch renamed the first shared file to a fixed
"renamed-by-test.dat" and never restored the original name. Against the
persistent daemon the suite targets, that (a) clobbered a real shared
file and (b) made the next run fail: renaming a file to its existing
name is a no-op amuled rejects with non-200, so the second run's
"PATCH name (rename) -> 200" bounced.

Capture the original name alongside the saved priority, rename to a name
guaranteed different from it (verifying the change lands with an
immediate GET), run the traversal/empty-name negative checks, then
restore the original name. jq builds the request body so odd characters
in a real filename are escaped. The file is now left exactly as found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build failure with pupnp 1.18.x (API change)

2 participants