Selected lines in Download/Shared lists become illegible when losing focus - #385
Merged
Merged
Conversation
Collaborator
|
Looks OK, but your commit message says remove but you just comented them. Could you really remove them? |
Contributor
Author
|
Oh, i was rebasing the branch, but i haven't made your requested change yet... is it ok if now is merged as commented code instead of fully removing it? |
Collaborator
|
Sorry, I had some PR's in mind that had just conflicts and have been to fast. |
got3nks
added a commit
to got3nks/amule
that referenced
this pull request
May 2, 2026
…3nks mrjimenez flagged on PR amule-project#514 review that these three contributors were missing from the roster: * Werner Mahr / Vollstrecker — has merge access on amule-project/amule and merges incoming PRs (e.g. amule-project#430, amule-project#385, amule-project#319, amule-project#330, amule-project#286). Goes under Maintainers based on that role. * Pablo Barciela / Sc0w — recent contributor, e.g. wxWidgets 3.2.6 build fixes, GTK version-check cleanup, dropping gtk1/gtk2 support, Chinese translation work. Goes under Developers. * got3nks — Wayland app_id binding + SNI tray (amule-project#508), macOS UX (amule-project#508), libmaxminddb CI fix (amule-project#507), ip2country/upnp/nls/boost hard-fail series (amule-project#509/amule-project#511/amule-project#512/amule-project#513), packaging (amule-project#510), docs modernize (this PR). Goes under Developers. Other recent folks may be missing too — those can be added in follow-up commits as they're identified. mrjimenez explicitly noted this is the priority subset to not block the rename PR.
mrjimenez
pushed a commit
that referenced
this pull request
May 2, 2026
…3nks mrjimenez flagged on PR #514 review that these three contributors were missing from the roster: * Werner Mahr / Vollstrecker — has merge access on amule-project/amule and merges incoming PRs (e.g. #430, #385, #319, #330, #286). Goes under Maintainers based on that role. * Pablo Barciela / Sc0w — recent contributor, e.g. wxWidgets 3.2.6 build fixes, GTK version-check cleanup, dropping gtk1/gtk2 support, Chinese translation work. Goes under Developers. * got3nks — Wayland app_id binding + SNI tray (#508), macOS UX (#508), libmaxminddb CI fix (#507), ip2country/upnp/nls/boost hard-fail series (#509/#511/#512/#513), packaging (#510), docs modernize (this PR). Goes under Developers. Other recent folks may be missing too — those can be added in follow-up commits as they're identified. mrjimenez explicitly noted this is the priority subset to not block the rename PR.
ngosang
added a commit
to ngosang/amule
that referenced
this pull request
Jul 10, 2026
…project#385) The router's RouteView showed the 'under construction' placeholder (app_coming_soon) whenever a section's dynamic import failed, disguising a real load error (network failure fetching the module, parse/eval error) as an unimplemented section. The error was also swallowed silently, leaving no diagnostic trail, and had no retry so the section stayed broken until navigating away and back. Since the web UI is complete, that placeholder should never appear. Both failure paths (import rejected, or module without a default export) now render a proper error placeholder and log the underlying error to the console. - app.js: rename the 'missing' state to 'failed'; log the real error in .catch and on missing default export; drop the obsolete 'mod.View' fallback and use mod.default directly; render kind="error" with app_view_error. - i18n (en/es): remove app_coming_soon, add app_view_error. - app.css: add .placeholder-error styling using the --bad error color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In several lists across amule, a selected line that loses focus becomes illegible because it is drawn with a white text on a white background.
There are a couple of ways to reproduce it: It happens when right-clicking on a line in the list. It also happens when selecting a line in the downloads/shared list (upper side of the window), and then clicking a line in the secondary list about clients (bottom side of the window).
The affected windows are: Downloads and Shared.
The Search window is not affected by this issue.
When comparing them, all of them use the same colour scheme, but the affected classes are using a Blend() on the colours, while the unaffected class isn't. The proposed change is to remove the Blend() on the colours from the affected classes.
Attaching a couple of screenshots before and after the fix.
The test environment has been Ubuntu 24.04, compiling the last version from master with wxWidgets 3.2.4 and boost 1.83.
Before: the third line is selected in the upper list, but when clicking on a peer in the bottom list, the line becomes illegible:
After: a line is selected in the upper list, and when clicking on a peer in the bottom list, the line can still be read: