Skip to content

Update Preferences.cpp: Changes location of GeoIP.dat.gz to solve the problem with identifying the flags/countries of users - #330

Merged
Vollstrecker merged 1 commit into
amule-project:masterfrom
topotech:master
Feb 24, 2026
Merged

Conversation

@topotech

Copy link
Copy Markdown
Contributor

Changing maintainer and provider of GeoIP.dat.gz in the meantime that other solution appears. This one is from https://mailfud.org/geoip-legacy/. This should fix issue #154

Changing maintainer and provider of GeoIP.dat.gz in the meantime that other solution appears. This one is from https://mailfud.org/geoip-legacy/. This should fix amule-project#154
@topotech topotech changed the title Update Preferences.cpp Update Preferences.cpp: Changes location of GeoIP.dat.gz to solve the problem with identifying the flags/countries of users Apr 21, 2022
@minnyres

Copy link
Copy Markdown

It may not work since aMule does not have https support.

@topotech

Copy link
Copy Markdown
Contributor Author

It may not work since aMule does not have https support.

Oh. Then you're right, it's almost sure it won't work if that's really the case. Wget shows the web server has a strict transport security policy.


$ wget http://mailfud.org/geoip-legacy/GeoIP.dat.gz
URL transformed to HTTPS due to an HSTS policy
--2022-04-25 01:21:55--  https://mailfud.org/geoip-legacy/GeoIP.dat.gz
...

@minnyres

Copy link
Copy Markdown

Oh. Then you're right, it's almost sure it won't work if that's really the case. Wget shows the web server has a strict transport security policy.

Nevertheless, it may work with this patch: #218.
I will make a test with it.

@minnyres

minnyres commented May 5, 2022

Copy link
Copy Markdown

Nevertheless, it may work with this patch: #218. I will make a test with it.

It's a good news that aMule can update ipfilter from https://mailfud.org/geoip-legacy/ if built with libcurl.
There is one more problem. This patch only sets the default address of ipfilter. If there is already a configuration file amule.conf, aMule will still use the address http://geolite.maxmind.com/download/geoip/database/GeoLiteCountry/GeoIP.dat.gz in the file.

@topotech

topotech commented May 6, 2022

Copy link
Copy Markdown
Contributor Author

I know, but after thinking about it for some time, I think it isn't a bad thing, because effectively someone could want a different server. I don't think it's bad this fix only works for new users.

@minnyres

minnyres commented May 7, 2022

Copy link
Copy Markdown

I don't think it's bad this fix only works for new users.

Yeah, old users may already have a geoip data file.

@Vollstrecker
Vollstrecker merged commit a7bd265 into amule-project:master Feb 24, 2026
got3nks added a commit to got3nks/amule that referenced this pull request May 2, 2026
…3nks

mrjimenez flagged on PR amule-project#514 review that these three contributors
were missing from the roster:

* Werner Mahr / Vollstrecker — has merge access on amule-project/amule
  and merges incoming PRs (e.g. amule-project#430, amule-project#385, amule-project#319, amule-project#330, amule-project#286). Goes
  under Maintainers based on that role.
* Pablo Barciela / Sc0w — recent contributor, e.g. wxWidgets 3.2.6
  build fixes, GTK version-check cleanup, dropping gtk1/gtk2 support,
  Chinese translation work. Goes under Developers.
* got3nks — Wayland app_id binding + SNI tray (amule-project#508), macOS UX
  (amule-project#508), libmaxminddb CI fix (amule-project#507), ip2country/upnp/nls/boost
  hard-fail series (amule-project#509/amule-project#511/amule-project#512/amule-project#513), packaging (amule-project#510),
  docs modernize (this PR). Goes under Developers.

Other recent folks may be missing too — those can be added in
follow-up commits as they're identified. mrjimenez explicitly noted
this is the priority subset to not block the rename PR.
mrjimenez pushed a commit that referenced this pull request May 2, 2026
…3nks

mrjimenez flagged on PR #514 review that these three contributors
were missing from the roster:

* Werner Mahr / Vollstrecker — has merge access on amule-project/amule
  and merges incoming PRs (e.g. #430, #385, #319, #330, #286). Goes
  under Maintainers based on that role.
* Pablo Barciela / Sc0w — recent contributor, e.g. wxWidgets 3.2.6
  build fixes, GTK version-check cleanup, dropping gtk1/gtk2 support,
  Chinese translation work. Goes under Developers.
* got3nks — Wayland app_id binding + SNI tray (#508), macOS UX
  (#508), libmaxminddb CI fix (#507), ip2country/upnp/nls/boost
  hard-fail series (#509/#511/#512/#513), packaging (#510),
  docs modernize (this PR). Goes under Developers.

Other recent folks may be missing too — those can be added in
follow-up commits as they're identified. mrjimenez explicitly noted
this is the priority subset to not block the rename PR.
mrjimenez pushed a commit to mrjimenez/amule that referenced this pull request Jul 16, 2026
…mule-project#499)

The interface bind added in amule-project#281 (IP_UNICAST_IF / IP_BOUND_IF) pins every
socket aMule opens — including the External Connection listener — to a single
interface, so ed2k/Kad cannot run over a VPN tunnel while the EC control port
stays on the LAN.

Decouple the EC listener with a new daemon-side setting,
/ExternalConnect/ECNetworkInterface (empty = any), that binds only aMule's EC
acceptor, independent of the global P2P interface pin. It sits beside the
existing ECAddress IP bind, giving the EC channel both its own IP and its own
interface.

CLibSocketServer gains a per-server interface override; only CExternalConnListener
uses it. ed2k/Kad TCP and UDP, outbound connections and HTTP keep following the
global setting untouched. A "Bind to network interface" selector is added to the
Remote Controls page (reusing the existing P2P label); like the other EC-listener
settings it is daemon-only — hidden in the remote GUI and not carried over EC —
and flagged restart-needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants