Set wxICON_INFORMATION as amule welcome icon - #295
Closed
eatradish wants to merge 1 commit into
Closed
Conversation
Obviously, this is not an Error and using wxICON_ERROR will confuse the user
mrjimenez
pushed a commit
to mrjimenez/amule
that referenced
this pull request
Jul 5, 2026
…ect#295) The preferences dialog's page list (General, Connection, Directories, etc.) fed 16x16 bitmaps into a fixed-size wxImageList, so on DPI-aware builds the icons render at 16 physical pixels — tiny and blurry on hi-DPI screens, same problem as the main toolbar (amule-project#294). Hand the icons to the list control as wxBitmapBundles instead (wxListCtrl::SetSmallImages, wx >= 3.2), each built from the 16px art plus a wxIMAGE_QUALITY_HIGH 2x upscale with the mask converted to an alpha channel first. The macOS-only right/bottom padding is applied per resolution so the padded canvas keeps its proportions at 2x. Co-authored-by: Carlos Barrero <[email protected]> Co-authored-by: Claude Fable 5 <[email protected]>
mrjimenez
pushed a commit
to mrjimenez/amule
that referenced
this pull request
Jul 5, 2026
…#307) Follow-up to amule-project#295: the old `#ifdef __WXOSX__` right/bottom pads (14/9) compensated for `AssignImageList`'s NSTableView render path — zero native icon/text gap plus vertical-centre-of-the-full-bitmap, which made a bare 16x16 icon sit flush against the label and drift toward the row baseline. `SetSmallImages` uses a different wxOSX path that already inserts native icon/text spacing, so the pads now render as visible extra whitespace between icon and label. Drop them (and the now-dead `img.Size()` pass) so wxOSX matches Windows/Linux layout. Verified locally: rebuilt on macOS 15 ARM64 (wxOSX Cocoa 3.3.2), page icons now sit at the natural offset the wx-native path picks. No change on wxGTK or wxMSW paths (both pads were already 0 there).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Obviously, this is not an Error and using wxICON_ERROR will confuse the user