Skip to content

Fix cppcheck [useInitializationList] warnings #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrjimenez merged 1 commit into from
Jun 7, 2026
Merged

Fix cppcheck [useInitializationList] warnings #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/AsyncDNS.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@

CAsyncDNS::CAsyncDNS(const wxString& ipName, DnsSolveType type, wxEvtHandler* handler, void* socket)
: wxThread(wxTHREAD_DETACHED)
, m_ipName(ipName.wc_str()) // make a deep copy to to circument the thread-unsafe wxString reference counting
{
m_type = type;
m_ipName = ipName.wc_str(); // make a deep copy to to circument the thread-unsafe wxString reference counting
m_socket = socket;
m_handler = handler;
}
Expand Down
2 changes: 1 addition & 1 deletion src/CanceledFileList.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@


CCanceledFileList::CCanceledFileList()
: m_filename("canceled.met")
{
m_filename = "canceled.met";
Init();
}

Expand Down
2 changes: 1 addition & 1 deletion src/Friend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ void CFriend::Init()


CFriend::CFriend( const CMD4Hash& userhash, uint32 tm_dwLastSeen, uint32 tm_dwLastUsedIP, uint32 tm_nLastUsedPort, uint32 tm_dwLastChatted, const wxString& tm_strName)
: m_UserHash(userhash)
{
m_dwLastSeen = tm_dwLastSeen;
m_dwLastUsedIP = tm_dwLastUsedIP;
m_nLastUsedPort = tm_nLastUsedPort;
m_dwLastChatted = tm_dwLastChatted;
m_UserHash = userhash;
m_HasFriendSlot = false;

if (tm_strName.IsEmpty()) {
Expand Down
2 changes: 1 addition & 1 deletion src/GapList.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ class CGapList {
public:
// constructs
const_iterator() {};
const_iterator(const ListType::const_iterator& it) { m_it = it; };
const_iterator(const ListType::const_iterator& it) : m_it(it) { };
// operators
bool operator != (const const_iterator& it) const { return m_it != it.m_it; }
const_iterator& operator ++ () { ++ m_it; return *this; }
Expand Down
4 changes: 2 additions & 2 deletions src/Tag.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@
// CTag

CTag::CTag(const wxString& Name)
: m_Name(Name)
{
m_uType = 0;
m_uName = 0;
m_Name = Name;
m_uVal = 0;
m_nSize = 0;
}
Expand All @@ -54,10 +54,10 @@ CTag::CTag(uint8 uName)
}

CTag::CTag(const CTag& rTag)
: m_Name(rTag.m_Name)
{
m_uType = rTag.m_uType;
m_uName = rTag.m_uName;
m_Name = rTag.m_Name;
m_nSize = 0;
if (rTag.IsStr()) {
m_pstrVal = new wxString(rTag.GetStr());
Expand Down
2 changes: 1 addition & 1 deletion src/TextClient.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@ enum {

// method to create a SearchFile
SearchFile::SearchFile(const CEC_SearchFile_Tag *tag)
: nHash(tag->FileHash())
{
nHash = tag->FileHash();
sHash = nHash.Encode();
sFileName = tag->FileName();
lFileSize = tag->SizeFull();
Expand Down
18 changes: 7 additions & 11 deletions src/utils/wxCas/src/onlinesig.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,18 +37,14 @@
OnLineSig::OnLineSig ( const wxFileName& file,
const double absoluteMaxDL,
const wxDateTime absoluteMaxDlDate )
: m_sessionMaxDL(0.0)
, m_sessionMaxDLDate(wxDateTime::Now())
, m_isSessionMaxDlReseted(false)
, m_absoluteMaxDL(absoluteMaxDL)
, m_absoluteMaxDlDate(absoluteMaxDlDate)
, m_isAbsoluteMaxDlReseted(false)
, m_amulesig(file)
{
m_amulesig = file;

m_sessionMaxDL = 0.0;
m_sessionMaxDLDate = wxDateTime::Now();

m_absoluteMaxDL = absoluteMaxDL;
m_absoluteMaxDlDate = absoluteMaxDlDate;

m_isSessionMaxDlReseted = false;
m_isAbsoluteMaxDlReseted = false;

Refresh ();
}

Expand Down
8 changes: 4 additions & 4 deletions src/webserver/src/WebSocket.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@
#endif

CWebSocket::CWebSocket(CWebServerBase *parent)
: m_dwBufSize(4096)
, m_dwRecv(0)
, m_dwHttpHeaderLen(0)
, m_dwHttpContentLen(0)
{
m_pHead = 0;
m_pTail = 0;
Expand All @@ -46,10 +50,6 @@ CWebSocket::CWebSocket(CWebServerBase *parent)
// `m_dwBufSize - m_dwRecv` reads below still leave the spare slot
// free for the terminator.
m_pBuf = new char [4096 + 1];
m_dwBufSize = 4096;
m_dwRecv = 0;
m_dwHttpHeaderLen = 0;
m_dwHttpContentLen = 0;
m_Cookie = 0;
m_IsGet = false;
m_IsPost = false;
Expand Down
Loading