Bugfix: API mismatch with crypto++ 6.0.0 - #120
Closed
TommyJerryMairo wants to merge 2 commits into
Closed
Conversation
Closed
Collaborator
|
I didn't check if you really get the same results with this, but have another question: Will this compile with pre-6 cryptopp, too? |
Contributor
it built correctly with cryptopp-5.6.3 |
gonosztopi
reviewed
Mar 21, 2018
| CryptoPP::RSASSA_PKCS1v15_SHA_Verifier pubkey(*static_cast<CryptoPP::RSASSA_PKCS1v15_SHA_Signer *>(m_pSignkey)); | ||
| CryptoPP::ArraySink asink(m_abyMyPublicKey, 80); | ||
| pubkey.DEREncode(asink); | ||
| pubkey.AccessMaterial().Save(asink); |
Member
There was a problem hiding this comment.
Although the use of AccessMaterial() complies with the comment on AsymmetricAlgorithm, I'd rather use GetMaterial() instead, because
- it returns a
constreference to the data, and - the original implementation used it too.
Contributor
There was a problem hiding this comment.
so could you fix this commit ? please
Contributor
Author
|
Updated. |
Member
|
Merged, the two commits squashed into one. |
got3nks
added a commit
to got3nks/amule
that referenced
this pull request
Jun 15, 2026
Reported in amule-project#162. The Server Info tab in the Network panel kept displaying messages from the disconnected server because there was no clear-on-disconnect path — the cumulative `server_msg` buffer (monolithic) and the diff-snapshot / on-screen text ctrl (amulegui post-amule-project#120) just kept accumulating. Adds a small ClearServerInfo() on each app variant: - CamuleApp::ClearServerInfo() — clears server_msg. - CamuleRemoteGuiApp::ClearServerInfo() — sends EC_OP_CLEAR_SERVERINFO to amuled and clears m_serverinfo_handler.m_seenSoFar. CamuleDlg::ShowConnectionState tracks the previous ed2k state via a static bool and on a connected -> disconnected transition calls both theApp->ClearServerInfo() (data) and ResetLog(ID_SERVERINFO) (UI). The dialog does the UI clear so the data-side method stays compilable in the daemon build (amuledlg lives on CamuleGuiBase which CamuleApp doesn't inherit).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in this issue, there is an API mismatch with
crypto++new version6.0.0so this commit is aiming to fix that mismatch.