Skip to content

Fixes: undefined reference to `MULE_EVT_LOGLINE' - #10

Merged
gonosztopi merged 1 commit into
amule-project:masterfrom
sc0w:master
Jan 3, 2016
Merged

Fixes: undefined reference to `MULE_EVT_LOGLINE'#10
gonosztopi merged 1 commit into
amule-project:masterfrom
sc0w:master

Conversation

@sc0w

@sc0w sc0w commented Nov 22, 2015

Copy link
Copy Markdown
Member

Fixes #9

@gonosztopi

Copy link
Copy Markdown
Member

Rejected.

Although I was the one who originally suggested this line be added to LoggerConsole.cpp, but it was never intended to be a fix, only a workaround. We should not add even more event-related code to a file that doesn't use events at all.

@gonosztopi gonosztopi closed this Dec 30, 2015
@gonosztopi gonosztopi reopened this Jan 3, 2016
@gonosztopi

Copy link
Copy Markdown
Member

Giving up for now.

It'd need a complete refactoring of both the logger and the libraries using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants