Labels: security · Severity: Medium
Location: src/webserver/src/WebSocket.cpp:250-255 (CWebSocket::SendHttpHeaders)
snprintf(cookie, sizeof(cookie), "Set-Cookie: amuleweb_session_id=%d\r\n", session_id);
Description: The session cookie is set with no security attributes. HttpOnly would
prevent JavaScript from reading it (mitigating XSS-based theft), and SameSite=Strict would
block the cross-site cookie attachment that makes CSRF (SEC-4) possible.
Impact: Amplifies XSS into session theft.
Suggested fix: Emit amuleweb_session_id=...; HttpOnly; SameSite=Strict (add Secure
when served over HTTPS / behind a TLS-terminating proxy).
Labels:
security· Severity: MediumLocation:
src/webserver/src/WebSocket.cpp:250-255(CWebSocket::SendHttpHeaders)Description: The session cookie is set with no security attributes.
HttpOnlywouldprevent JavaScript from reading it (mitigating XSS-based theft), and
SameSite=Strictwouldblock the cross-site cookie attachment that makes CSRF (SEC-4) possible.
Impact: Amplifies XSS into session theft.
Suggested fix: Emit
amuleweb_session_id=...; HttpOnly; SameSite=Strict(addSecurewhen served over HTTPS / behind a TLS-terminating proxy).