Skip to content

Several remote.conf settings are read but never written back (ZLIB, PageRefreshTime) #817

Description

@ngosang

A few settings are loaded from remote.conf at startup but are missing from the corresponding SaveConfigFile() methods, so they can never be persisted by the tools — they only survive if the user edits the file by hand.

/EC/ZLIB — read in CaMuleExternalConnector::LoadConfigFile() but not written in SaveConfigFile():

// ExternalConnector.cpp:613 (LoadConfigFile)
m_ZLIB = m_configFile->Read("/EC/ZLIB", 1l) != 0;
// ExternalConnector.cpp:617-630 (SaveConfigFile) — writes /Locale, /EC/Host, /EC/Port, /EC/Password
// but never /EC/ZLIB

/Webserver/PageRefreshTime — read in CamulewebApp::LoadConfigFile() but not written in SaveConfigFile():

// WebInterface.cpp:447 (LoadConfigFile)
m_PageRefresh = m_configFile->Read("/Webserver/PageRefreshTime", 120l);
// WebInterface.cpp:452-466 (SaveConfigFile) — writes Port, UPnPWebServerEnabled, UPnPTCPPort,
// Template, UseGzip, AllowGuest, AdminPassword, GuestPassword — but never PageRefreshTime

Effect: the asymmetry is confusing and means these values cannot be changed/persisted through the normal save path. Either they should be added to the matching SaveConfigFile() (so they round-trip like every other key), or, if read-only-by-design is intended, it should be documented as such.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions