…iles via ffprobe (amule-project#280) * feat(mediaprobe): ffprobe subprocess module for local media metadata Standalone module that fronts an ffprobe subprocess to extract length / bitrate / codec from local shared files. Wiring into share-add and Preferences follows in subsequent commits. MediaProbe::AutoDetectPath() locates a usable binary in two steps: first a bare `ffprobe -version` invocation to catch the PATH-installed case, then a per-platform well-known-paths scan (Homebrew + MacPorts on macOS; Chocolatey + Scoop + WinGet layouts on Windows; distro- standard prefixes plus /snap/bin on Linux + OpenBSD). Fallback matters because GUI-launched processes get a minimal PATH on macOS (launchd default lacks /opt/homebrew) and unreliable PATH on Windows (system- level updates from Chocolatey install don't always propagate to running processes). MediaProbe::Probe() forks ffprobe with `-of default=nk=0:nw=1` so the output is a bare `key=value` stream — no JSON parser dependency needed (the tree has none). Length rounds to whole seconds (FT_MEDIA_LENGTH's wire format is uint32), bit_rate is converted from bps to kbps (FT_MEDIA_BITRATE), and the first stream's codec_name wins (video for video containers, audio for audio-only). Failures emit debug log lines but never surface user-visible errors — a file the probe can't read still shares fine, just without media tags. Boolean return with out-param instead of std::optional so the module matches the existing tree's C++ style. Callers MUST run Probe() off the main thread; a subsequent commit extends SharedFileList's batch path to do so. Prep for amule-project#140 Phase B — advertising media metadata from own shared files to ed2k servers + Kad. * feat(sharing): publish FT_MEDIA_{LENGTH,BITRATE,CODEC} to ed2k + Kad The Kad publisher at kademlia/kademlia/Search.cpp:1422 already iterates the file's media tags — but gates the whole emit on `file->GetMetaDataVer() > 0`. GetMetaDataVer had been a longstanding stub returning a hardcoded 0 with a TODO comment, so the code path was dead: no ed2k client has ever seen media metadata from an aMule-shared file. The ed2k server publish path (CreateOfferedFilePacket) had a matching stub — a comment reading "There, we could add MetaData info, if we ever get to have that." that built its outgoing tag list without touching m_taglist for media entries. Un-stub both: - GetMetaDataVer now derives from FT_MEDIA_LENGTH tag presence. No new persisted field: MediaProbe is the only source of the tag, and the tag itself already rides through known.met via the existing m_taglist load/save. Non-zero length is the "we've probed and have data worth publishing" signal, which is exactly what Kad's gate needs. - CreateOfferedFilePacket appends FT_MEDIA_LENGTH / FT_MEDIA_BITRATE as CTagVarInt (VBT-encoded for capable eMule clients + TYPETAG- INTEGER-capable servers, fixed 32-bit otherwise) and FT_MEDIA_CODEC as CTagString when the corresponding tag is present and non-empty / non-zero. Each tag is optional per file; a file with only length publishes only length. Prep for amule-project#140 Phase B — once MediaProbe wiring lands in SharedFileList's share-add path, tags flow to peers automatically. No change to known.met format (m_taglist already covers the persistence layer). * feat(prefs): [MediaMetadata]/Enabled + FFProbePath + UI panel Preferences plumbing for amule-project#140's ffprobe subprocess. Cfg items live in a fresh /MediaMetadata/ config namespace (won't clash with any /eMule/ key) with Enabled default false — an upgraded install won't kick off background probing until the user opts in from Preferences -> Files. UI panel goes at the bottom of PreferencesFilesTab: an Enable checkbox plus a "Path to ffprobe:" row with text field, Browse and Detect buttons. Browse routes through the existing OnButtonBrowseApplication switch (same file-selector infra the video-player / browser fields use). Detect fires MediaProbe::AutoDetectPath() and either populates the field or shows a friendly "install ffmpeg or Browse manually" info dialog. The whole box hides in amulegui via PrefsUnifiedDlg's amuledOnlyPrefs[] — probing runs daemon-side, the remote GUI has no business setting the path. IDC IDs sit in the 10420-10423 functional band and 10370 orphan- label slot, chosen to leave a 10-ID cushion above bind-to- interface's IDC_INTERFACE = 10410 so parallel branches can grow without collision. MediaProbe moves to COMMON_SOURCES so the Detect button's handler still links in remote-GUI builds (the button is hidden there but the event-table binding still needs the symbol). Follow-ups on the same branch: SharedFileList wiring (probe on share-add + known.met load), extension gate, background-probe throttling. * feat(shared): probe media metadata off-main + attach to CKnownFile Closes the amule-project#140 wiring loop: shared audio / video files now get probed with ffprobe, and the resulting FT_MEDIA_LENGTH / _BITRATE / _CODEC tags are attached to the CKnownFile so the earlier ed2k + Kad publisher un-stubs pick them up. Threading + throttling: - New CMediaProbeTask (ETP_Low) rides on the existing CThreadScheduler queue. That queue serialises tasks — a large library at first-boot-after-upgrade retrofits one file at a time, never stepping on hashing or completion which run at higher priority. No custom thread pool. - Task ctor snapshots the ffprobe path so the worker never touches thePrefs, and remembers just the file's CMD4Hash + CPath. Result marshals back via CMediaProbeEvent (new MULE_EVT_MEDIA_PROBE), main thread resolves the hash to a live CKnownFile via CKnownFileList::FindKnownFileByID (the file may have been unshared while we were probing) and calls AddTagUnique for each populated field, MarkECChanged, and knownfiles->Save so the tags survive a crash. Gating: - Preference /MediaMetadata/Enabled must be true AND FFProbePath non-empty. - Extension gate: only ED2KFT_AUDIO or ED2KFT_VIDEO files (from GetED2KFileTypeID) — skips the mass of docs / archives / images a typical share tree carries. - Already-probed gate: skip when FT_MEDIA_LENGTH > 0. This is the retrofit cache — once a file has been probed successfully its tag rides through known.met and future launches skip re-probing. Hook site is CSharedFileList::AddFile — the single choke point for both runtime share-adds (user picks a new folder / drops a file in Incoming) AND Reload()'s known.met walk, so an upgraded install retrofits every existing shared file on the first launch after the user enables the feature. No separate load-vs-add code path. Event-table bindings for MULE_EVT_MEDIA_PROBE landed in both amuled.cpp (daemon) and amule-gui.cpp (monolithic / remote GUI) so the handler fires regardless of which app the scheduler dispatched from. * chore(clang-format): apply clang-format-18 to amule-project#140 files * i18n(pot): regenerate catalogs for amule-project#140 UI additions Rerun of scripts/update-po.sh on top of the post-amule-project#281 (bind-to- interface) master so the Media metadata strings coexist with the new bind-to-interface strings. Replaces the earlier standalone regen that was skipped during the rebase. * feat(prefs): gray out ffprobe path controls when Media metadata is off The [MediaMetadata] Enabled checkbox now drives the enabled state of IDC_MEDIAMETA_FFPROBEPATHTEXT / _FFPROBEPATH / _FFPROBEBROWSE / _FFPROBEDETECT via the existing OnCheckBoxChange handler, and the initial state is applied at dialog open. Previously the path input, Browse and Detect buttons stayed live-looking with the feature disabled, which read as "I can configure ffprobe here" while nothing downstream would ever run.

Uh oh!

wishlist: amulecmd extension #280

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions