Skip to content

api-changes in upnp #274

Description

@Vollstrecker

amule fails compile against latest libupnp

/home/runner/work/amule/amule/src/UPnPBase.cpp:447:16: error: cannot convert ‘const char*’ to ‘UpnpLib*’ {aka ‘s_UpnpLib*’}
  447 |   URLBase.c_str(),
      |   ~~~~~~~~~~~~~^~
      |                |
      |                const char*
In file included from /home/runner/work/amule/amule/src/UPnPCompatibility.h:32,
                 from /home/runner/work/amule/amule/src/UPnPBase.h:36,
                 from /home/runner/work/amule/amule/src/UPnPBase.cpp:36:
/home/runner/work/amule/amule/build/_deps/pupnp-src/upnp/inc/upnptools.h:89:18: note:   initializing argument 1 of ‘int UpnpResolveURL(UpnpLib*, const char*, const char*, char*)’
   89 |         UpnpLib *p,
      |         ~~~~~~~~~^

And so on...
I think this time a version-switch is needed to support old and new interface. Luckily the version is defined in upnpconfig.h

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions