docs(compilation): ENABLE_IP2COUNTRY default → YES - #179
Merged
Conversation
Tracks amule-org/amule#119 (merged 2026-06-12): ENABLE_IP2COUNTRY now defaults to YES with a configure-time hard-fail if libmaxminddb is missing, matching how ENABLE_NLS and ENABLE_UPNP have always worked. docs/developer/compilation/index.md: - Build-options table: ENABLE_IP2COUNTRY default flipped NO → YES. - BUILD_EVERYTHING note: ENABLE_IP2COUNTRY is no longer the odd-one-out that needed an explicit -DENABLE_IP2COUNTRY=YES; rewrite to list it alongside ENABLE_NLS and ENABLE_UPNP as a default-on toggle. docs/developer/compilation/linux.md: - "libmaxminddb not found" troubleshooting paragraph: users hitting the FATAL_ERROR now usually didn't explicitly opt in; rewrite to name the default-YES behaviour as the trigger and point at the install-or-opt-out fix. The per-OS Quick Start cmake invocations (linux/macos/windows/bsd) keep their explicit -DENABLE_IP2COUNTRY=YES — the doc style elsewhere is "list every ENABLE_* explicitly even when it matches the default", same as the existing -DENABLE_NLS=YES / -DENABLE_UPNP=YES entries. Value still matches the new default.
Contributor
Author
|
Sorry @ngosang I think I might have fucked up Weblate with this PR. |
Member
|
@got3nks don't worry, you can't fuck Weblate. https://github.com/orgs/amule-org/discussions/6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tracks amule-org/amule#119 (merged 2026-06-12):
ENABLE_IP2COUNTRYnow defaults toYESwith a configure-time hard-fail iflibmaxminddbis missing, matching howENABLE_NLSandENABLE_UPNPhave always worked.Fix
docs/developer/compilation/index.md:ENABLE_IP2COUNTRYdefault flippedNO→YES.BUILD_EVERYTHINGnote: it no longer needs the "but you must add-DENABLE_IP2COUNTRY=YES" qualifier; rewrite to list IP2COUNTRY alongside NLS and UPNP as default-on toggles.docs/developer/compilation/linux.md:libmaxminddbnot found" troubleshooting paragraph: users hitting theFATAL_ERRORnow usually didn't explicitly opt in; rewrite to name the default-YES behaviour as the trigger and point at the install-or-opt-out fix.The per-OS Quick Start
cmakeinvocations (linux/macos/windows/bsd) keep their explicit-DENABLE_IP2COUNTRY=YES— the doc style elsewhere is "list everyENABLE_*explicitly even when it matches the default", same as the existing-DENABLE_NLS=YES/-DENABLE_UPNP=YESentries. Value still matches the new default, so no change needed.