fix(webserver): make the login error message readable - #96
Merged
Conversation
The failed-login message was dark red (#c00000) bold text sitting directly on the mid-blue gradient of the login banner image -- nearly illegible. Render it as white text on a solid red badge instead (inline-block span with padding), which reads clearly on the banner. The rule lives in login.php's inline <style> block because style.css is not served to unauthenticated clients (see the modernization notes), and this message only ever renders on the login page. Verified against the running webserver with a headless-Chromium screenshot of a wrong-password submit; the error-free login page is pixel-identical to before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failed-login message was dark red (#c00000) bold text sitting directly on the mid-blue gradient of the login banner image -- nearly illegible. Render it as white text on a solid red badge instead (inline-block span with padding), which reads clearly on the banner.
The rule lives in login.php's inline <style> block because style.css is not served to unauthenticated clients (see the modernization notes), and this message only ever renders on the login page.
Verified against the running webserver with a headless-Chromium screenshot of a wrong-password submit; the error-free login page is pixel-identical to before.