refactor(webserver): remove common.js, its MM_nbGroup handlers were no-ops - #93
Merged
Merged
Conversation
…o-ops common.js only held the Dreamweaver leftovers MM_nbGroup and its helper MM_findObj. Every remaining call site (the downloads and shared-files toolbars) passed empty strings as the swap-image arguments, so every code path ended up reassigning the src the image already had — the buttons have no hover/down image variants, and the onClick navigation (formCommandSubmit) reloads the page anyway. Pure dead weight. - Drop the onClick/onMouseOver/onMouseOut MM_nbGroup attributes from the 10 toolbar links (6 in amuleweb-main-dload.php, 4 in amuleweb-main-shared.php); the formCommandSubmit hrefs are untouched. - Remove the <script src="common.js"> tag from the 8 main pages. - Delete common.js and its entry in the CMake INSTALL list. Verified against a running amuleweb: all pages load with a clean JS console, the toolbar buttons still submit their commands, and the toolbars render identically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
common.js only held the Dreamweaver leftovers MM_nbGroup and its helper MM_findObj. Every remaining call site (the downloads and shared-files toolbars) passed empty strings as the swap-image arguments, so every code path ended up reassigning the src the image already had — the buttons have no hover/down image variants, and the onClick navigation (formCommandSubmit) reloads the page anyway. Pure dead weight.
Verified against a running amuleweb: all pages load with a clean JS console, the toolbar buttons still submit their commands, and the toolbars render identically.