refactor(webserver): consolidate inline <style> blocks into style.css - #89
Merged
Merged
Conversation
Every page of the default template embedded an almost identical ~80-line <style> block that duplicated and overrode style.css. Remove the inline blocks from the 11 pages carrying the common block and make style.css the single source of truth, preserving the styling that was effectively rendered before: - a:hover color becomes #c0c0c0 (the inline value that always won over the #FFFFFF in style.css). - .texte absorbs the text-overflow/ellipsis extras used by the downloads, shared and search pages. - The page-specific column widths move to dedicated classes: .texte-full-name (45%), .texte-full-name-upload (55%) and the new .texte-full-name-search (75%), now referenced from the search page. - textarea keeps the inline values (#90B6DB background, white text); no <textarea> exists in the template so this is dead CSS either way. - The duplicated label rule is merged (the later trebuchet ms 12px rule was the effective one) and the invalid font-height property is gone. stats.php had no stylesheet link at all, so its inline block is replaced by the <link> to style.css. log.php and stats_tree.php only contain page-specific styles and are left for a later cleanup (item 17 of the modernization plan). Verified against a running amuleweb: all 11 pages return 200 with no <style> block and one style.css link, and style.css is served as text/css matching the new content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every page of the default template embedded an almost identical ~80-line <style> block that duplicated and overrode style.css. Remove the inline blocks from the 11 pages carrying the common block and make style.css the single source of truth, preserving the styling that was effectively rendered before:
stats.php had no stylesheet link at all, so its inline block is replaced by the to style.css. log.php and stats_tree.php only contain page-specific styles and are left for a later cleanup (item 17 of the modernization plan).
Verified against a running amuleweb: all 11 pages return 200 with no <style> block and one style.css link, and style.css is served as text/css matching the new content.