fix(webserver): correct structural HTML errors in default template - #87
Merged
Merged
Conversation
Fix several invalid-markup issues across the default template pages, with no visual or behavioral change intended: - stats.php: the document went straight from </head> to <table> and ended at </html>; add the missing <body> and </body> tags. - log.php: replace the invalid <code><pre> nesting with <pre> alone, and drop the <meta http-equiv="pragmas"> tag (a typo for "pragma", and redundant anyway since every response already carries Cache-Control: no-cache headers). - amuleweb-main-search.php: the search results header <th> cells had no opening <tr>, and each result row was closed with a duplicated </tr></tr>. - footer.php: add the missing </tr> before </table>. - amuleweb-main-prefs.php: the "Page refresh interval" row content was missing its opening <tr>. - amuleweb-main-dload.php: remove the duplicated attribute in the toolbar's <img img name=...> tags, a duplicated border="0" on the filter button image, and the empty onLoad=""/onload="" attributes. - login.php: drop the stray valign="middle" from <body>, which is not a valid body attribute. Part of the P2 markup cleanup in .claude/WEBUI_MODERNIZATION.md (item 11, "Structural HTML errors").
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix several invalid-markup issues across the default template pages, with no visual or behavioral change intended: