fix(webserver): guard division by zero in downloads page percentages - #83
Merged
Merged
Conversation
The downloads page of the default template computes two completion percentages with an unguarded division: - the per-file column divides size_done by the file size, which is zero for 0-byte files; - the totals row divides the completed sum by the accumulated total size, which stays at zero whenever the status/category filter matches no files (the row is printed as long as the unfiltered list is non-empty). In the second case the page rendered "-nan%" in the Total row. Guard both expressions with a ternary that falls back to 0 when the divisor is zero, matching the style already used elsewhere in the template. Verified against a running amuleweb: with downloads present the percentages are unchanged, and with a filter matching no files the totals row now shows "0 b (0%)" instead of "-nan%".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The downloads page of the default template computes two completion percentages with an unguarded division:
In the second case the page rendered "-nan%" in the Total row. Guard both expressions with a ternary that falls back to 0 when the divisor is zero, matching the style already used elsewhere in the template.
Verified against a running amuleweb: with downloads present the percentages are unchanged, and with a filter matching no files the totals row now shows "0 b (0%)" instead of "-nan%".