fix(webserver): show login error message on failed login - #82
Merged
Conversation
The webserver backend sets $_SESSION["login_error"] when a login attempt fails (wrong password, invalid hash, or no password configured), but login.php never printed it: a wrong password just re-rendered the login form with no feedback, leaving the user with no clue why they were not logged in. Echo the session variable next to the login form, styled in red, when it is non-empty. The message is a static server-provided string (WebServer.cpp), so no escaping is needed. The error only shows on the response to the failed attempt itself, since the backend resets login_error at the start of every request. Verified against a running amuleweb: a wrong password now renders "Password incorrect, please try again." under the form, a fresh visit shows no message, and the correct password still logs in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The webserver backend sets $_SESSION["login_error"] when a login attempt fails (wrong password, invalid hash, or no password configured), but login.php never printed it: a wrong password just re-rendered the login form with no feedback, leaving the user with no clue why they were not logged in.
Echo the session variable next to the login form, styled in red, when it is non-empty. The message is a static server-provided string (WebServer.cpp), so no escaping is needed. The error only shows on the response to the failed attempt itself, since the backend resets login_error at the start of every request.
Verified against a running amuleweb: a wrong password now renders "Password incorrect, please try again." under the form, a fresh visit shows no message, and the correct password still logs in.