fix(webserver): make footer's "Download link" refresh the main page - #81
Merged
Conversation
refreshFrames() was broken in two ways: it assigned a new URL to 'location' and immediately called location.reload(), so the reload cancelled/duplicated the navigation; and since footer.php runs inside an iframe, 'location' only ever pointed at the iframe itself, never the main page. On top of that it ran from the submit button's onClick, i.e. before the form was actually submitted, racing the POST that adds the ed2k link. Fix by navigating the top window once via window.top.location, and only after the form round-trip: the onClick handler and the refreshFrames() function are removed, and footer.php now emits a one-line script in its response only when the Submit parameter is present, i.e. after the server has already processed the ed2k link. The main page then reloads on amuleweb-main-dload.php and shows the new download. Item 6 (P1) of .claude/WEBUI_MODERNIZATION.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refreshFrames() was broken in two ways: it assigned a new URL to 'location' and immediately called location.reload(), so the reload cancelled/duplicated the navigation; and since footer.php runs inside an iframe, 'location' only ever pointed at the iframe itself, never the main page. On top of that it ran from the submit button's onClick, i.e. before the form was actually submitted, racing the POST that adds the ed2k link.
Fix by navigating the top window once via window.top.location, and only after the form round-trip: the onClick handler and the refreshFrames() function are removed, and footer.php now emits a one-line script in its response only when the Submit parameter is present, i.e. after the server has already processed the ed2k link. The main page then reloads on amuleweb-main-dload.php and shows the new download.