fix(webserver): re-encode shared files page as UTF-8 with English alttexts - #80
Merged
Merged
Conversation
… texts
amuleweb-main-shared.php was the only template file encoded in
ISO-8859-1 while every page declares a UTF-8 charset, so the toolbar
tooltips rendered as mojibake ("Alza Priorit?"). On top of that, the
four toolbar alt texts were in Italian on an otherwise English UI.
Translate the alt texts to English ("Reload shared files", "Raise
priority", "Lower priority", "Set priority"), which also removes the
only non-ASCII bytes in the file, making it plain ASCII / valid UTF-8
like the rest of the template.
Verified against a running amuleweb: the served page is valid UTF-8
and the tooltips render correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
amuleweb-main-shared.php was the only template file encoded in ISO-8859-1 while every page declares a UTF-8 charset, so the toolbar tooltips rendered as mojibake ("Alza Priorit?"). On top of that, the four toolbar alt texts were in Italian on an otherwise English UI.
Translate the alt texts to English ("Reload shared files", "Raise priority", "Lower priority", "Set priority"), which also removes the only non-ASCII bytes in the file, making it plain ASCII / valid UTF-8 like the rest of the template.
Verified against a running amuleweb: the served page is valid UTF-8 and the tooltips render correctly.