fix(webserver): correct MByte/GByte multipliers in search size filters - #76
Merged
Merged
Conversation
str2mult() in the default template's search page converted the min/max size filter units using 1012*1024 for MByte and 1012*1024*1024 for GByte instead of 1024*1024 and 1024*1024*1024, a typo that made every size-filtered search off by ~1.2%. A search filtered to "min 700 MByte" actually asked the core for files >= 726,663,168 bytes instead of 734,003,200, silently excluding or including files near the boundary. Use the correct power-of-two multipliers so the filter matches the units shown in the search form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
str2mult() in the default template's search page converted the min/max size filter units using 10121024 for MByte and 101210241024 for GByte instead of 10241024 and 102410241024, a typo that made every size-filtered search off by ~1.2%. A search filtered to "min 700 MByte" actually asked the core for files >= 726,663,168 bytes instead of 734,003,200, silently excluding or including files near the boundary.
Use the correct power-of-two multipliers so the filter matches the units shown in the search form.