fix(webserver): sorting downloads by sources never worked - #75
Merged
Conversation
The "Sources" column header in the downloads page links to ?sort=srccount, but the my_cmp() comparator used by usort() matched the misspelled case label "scrcount". The switch therefore never matched, the comparison result stayed unset, and clicking the header only flipped the whole list via the session reverse flag instead of ordering rows by source count. Fix the case label to "srccount" so it matches the value sent by the header link (and stored in the session), making the column sort by $file->src_count as intended. Verified against a running amuleweb with three downloads having 0, 4 and 32 sources: before the fix ?sort=srccount returned them in daemon order (or its reverse); after the fix it returns them ordered 0/4/32 ascending and 32/4/0 on the second click.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Sources" column header in the downloads page links to ?sort=srccount, but the my_cmp() comparator used by usort() matched the misspelled case label "scrcount". The switch therefore never matched, the comparison result stayed unset, and clicking the header only flipped the whole list via the session reverse flag instead of ordering rows by source count.
Fix the case label to "srccount" so it matches the value sent by the header link (and stored in the session), making the column sort by $file->src_count as intended.
Verified against a running amuleweb with three downloads having 0, 4 and 32 sources: before the fix ?sort=srccount returned them in daemon order (or its reverse); after the fix it returns them ordered 0/4/32 ascending and 32/4/0 on the second click.