fix(amuleweb): remove copy-pasted preferences code from log page - #74
Merged
Merged
Conversation
amuleweb-main-log.php contained a verbatim copy of the preferences page's option-apply PHP block and its init_data() JavaScript helper, left over from copy-pasting the page skeleton. This caused three problems on every Log page view: - visiting amuleweb-main-log.php?Submit=Apply&... silently rewrote the daemon preferences with mostly-zero values, since the copied block called amule_set_options() with whatever (usually empty) query parameters were present; - the body onLoad called init_data(), which threw a JavaScript TypeError because the Log page has no "mainform" form; - an unnecessary amule_get_options() round-trip to the core on every page load. Remove the whole script block (formCommandSubmit and initvals were also unused prefs leftovers) and the init_data() call from onLoad. Verified against a running webserver: the Log page renders as before, and loading it with ?Submit=Apply no longer changes any daemon preference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
amuleweb-main-log.php contained a verbatim copy of the preferences page's option-apply PHP block and its init_data() JavaScript helper, left over from copy-pasting the page skeleton. This caused three problems on every Log page view:
Remove the whole script block (formCommandSubmit and initvals were also unused prefs leftovers) and the init_data() call from onLoad.
Verified against a running webserver: the Log page renders as before, and loading it with ?Submit=Apply no longer changes any daemon preference.