feat(gui): remove the global Connect/Disconnect toolbar button - #663

…l/Disconnect toggles

Relocates the removed global toolbar button's functionality into the
ED2K (IDC_ED2KDISCONNECT) and Kad (ID_KADDISCONNECT) panes instead of
just dropping it, per got3nks's proposal on amule-org#663: each button now
mirrors ed2kState/kadState (off/connecting/connected) using the
existing connButImg() bitmaps, and can independently connect or
cancel/disconnect its own network -- something the old OR-toggled
global button never allowed. The ED2K pane also gains a Connect
button it never had (previously Disconnect-only).

CServerWnd::UpdateED2KConnectButton() / CKadDlg::UpdateConnectButton()
are called from CamuleDlg::ShowConnectionState() alongside the
existing UpdateED2KInfo()/UpdateKadInfo() calls, and once from each
pane's own ctor/Init() for the initial paint. OnBnClickedED2KDisconnect
and OnBnClickedDisconnectKad gained the missing "connect when off"
branch; OnBnConnect and the tray icon are untouched.

Verified interactively on Windows: both buttons show the correct
label/icon for their live state, ED2K disconnect/reconnect works from
its own button, and disabling ED2K in Preferences while Kad stays
connected confirms the two toggle independently.

Co-Authored-By: Claude Sonnet 5 <[email protected]>

…l/Disconnect toggles

Relocates the removed global toolbar button's functionality into the
ED2K (IDC_ED2KDISCONNECT) and Kad (ID_KADDISCONNECT) panes instead of
just dropping it, per got3nks's proposal on amule-org#663: each button now
mirrors ed2kState/kadState (off/connecting/connected) using the
existing connButImg() bitmaps, and can independently connect or
cancel/disconnect its own network -- something the old OR-toggled
global button never allowed. The ED2K pane also gains a Connect
button it never had (previously Disconnect-only).

CServerWnd::UpdateED2KConnectButton() / CKadDlg::UpdateConnectButton()
are called from CamuleDlg::ShowConnectionState() alongside the
existing UpdateED2KInfo()/UpdateKadInfo() calls, and once from each
pane's own ctor/Init() for the initial paint. OnBnClickedED2KDisconnect
and OnBnClickedDisconnectKad gained the missing "connect when off"
branch; OnBnConnect and the tray icon are untouched.

Verified interactively on Windows: both buttons show the correct
label/icon for their live state, ED2K disconnect/reconnect works from
its own button, and disabling ED2K in Preferences while Kad stays
connected confirms the two toggle independently.

po/ regenerated via scripts/update-po.sh to match the new button
labels ("Disconnect Kad" is now unused and moves to the obsolete
section; no new translatable strings).

Co-Authored-By: Claude Sonnet 5 <[email protected]>

…l/Disconnect toggles

Relocates the removed global toolbar button's functionality into the
ED2K (IDC_ED2KDISCONNECT) and Kad (ID_KADDISCONNECT) panes instead of
just dropping it, per got3nks's proposal on amule-org#663: each button now
mirrors ed2kState/kadState (off/connecting/connected) using the
existing connButImg() bitmaps, and can independently connect or
cancel/disconnect its own network -- something the old OR-toggled
global button never allowed. The ED2K pane also gains a Connect
button it never had (previously Disconnect-only).

CServerWnd::UpdateED2KConnectButton() / CKadDlg::UpdateConnectButton()
are called from CamuleDlg::ShowConnectionState() alongside the
existing UpdateED2KInfo()/UpdateKadInfo() calls, and once from each
pane's own ctor/Init() for the initial paint. OnBnClickedED2KDisconnect
and OnBnClickedDisconnectKad gained the missing "connect when off"
branch; OnBnConnect and the tray icon are untouched.

Verified interactively on Windows: both buttons show the correct
label/icon for their live state, ED2K disconnect/reconnect works from
its own button, and disabling ED2K in Preferences while Kad stays
connected confirms the two toggle independently.

po/ regenerated via scripts/update-po.sh to match the new button
labels ("Disconnect Kad" is now unused and moves to the obsolete
section; no new translatable strings).

Co-Authored-By: Claude Sonnet 5 <[email protected]>

got3nks flagged two bugs in review (PR amule-org#663): the static cache's
early return also skipped Enable(), so the button could get stuck
disabled once IsReady()/network-pref state changed without the
Connect/Cancel/Disconnect state itself changing (master had two now-
deleted escape hatches -- the skinChanged force-path and an
unconditional EnableTool call -- that used to paper over this). Worse,
the cache was function-scope static, surviving widget recreation, so
a fresh pane's Init() call could early-return and leave the wxDesigner
default label ("Disconnect Kad") on screen.

Dropping the cache removes both: SetLabel/SetBitmap/Enable are cheap
on a plain wxButton (unlike the old toolbar tool, which had real
native-image-list reasons to memoize, see amuleDlg.cpp:1054-ish), and
master's own second call site already did an unconditional EnableTool
every tick without issue.

Verified interactively on Windows: re-tested full disconnect/reconnect
cycle on both panes, plus toggling ED2K off and back on via
Preferences (which now requires an app restart to re-enable, existing
behavior) -- on the fresh post-restart paint, both buttons show the
correct live state immediately. Also confirmed amulegui (CLIENT_GUI)
builds clean with these changes; did not perform full interactive
remote-daemon testing.

got3nks flagged two bugs in review (PR amule-org#663): the static cache's
early return also skipped Enable(), so the button could get stuck
disabled once IsReady()/network-pref state changed without the
Connect/Cancel/Disconnect state itself changing (master had two now-
deleted escape hatches -- the skinChanged force-path and an
unconditional EnableTool call -- that used to paper over this). Worse,
the cache was function-scope static, surviving widget recreation, so
a fresh pane's Init() call could early-return and leave the wxDesigner
default label ("Disconnect Kad") on screen.

Dropping the cache removes both: SetLabel/SetBitmap/Enable are cheap
on a plain wxButton (unlike the old toolbar tool, which had real
native-image-list reasons to memoize, see amuleDlg.cpp:1054-ish), and
master's own second call site already did an unconditional EnableTool
every tick without issue.

Verified interactively on Windows: re-tested full disconnect/reconnect
cycle on both panes, plus toggling ED2K off and back on via
Preferences (which now requires an app restart to re-enable, existing
behavior) -- on the fresh post-restart paint, both buttons show the
correct live state immediately. Also confirmed amulegui (CLIENT_GUI)
builds clean with these changes; did not perform full interactive
remote-daemon testing.

…RL (#677)

Follow-ups to #663:

- Give the Kad tab the same full-width first row as the ED2K pane: the
  nodes-list URL refresher (update button, label, URL entry) with the
  connect/disconnect toggle right-aligned, above the stats graph and the
  Bootstrap box. Previously the toggle sat inside the 2-column grid, so a
  right-aligned toggle landed mid-pane instead of at the pane edge.

- macOS rendered the server-list and nodes-list URL entries two lines
  tall: their rows carry an icon-bearing button (taller than a one-line
  field on macOS) and the entries used Expand(), which stretched them to
  match. Switch both to CenterVertical() (still proportion 1 horizontally)
  so they stay one line.

…age (#685)

The Networks tab strip carried a single ConnectButton that toggled ED2K and
Kad together, while each tab had its own state-blind Connect/Disconnect
buttons. That mirrored neither the REST API (already symmetric via
POST /networks/{connect,disconnect} with {network: "ed2k"|"kad"|"both"}) nor
amulegui after #663/#677, and it meant only the global button reflected the
actual connection state.

Each network tab now owns one state-aware toggle for its own network. Colour
and label follow the real state from the SSE status_changed event — a
red/amber/green plug reading "ED2K: Connected", "Kad: Connecting…" — while the
click performs the opposite action. "connecting" counts as up, so a Kad that is
running-but-not-routing (the backend collapses that into "connecting") stays
stoppable; this matches CKadDlg::OnBnClickedDisconnectKad. There is no
confirmation dialog, matching the buttons it replaces. Disconnecting both
networks at once is no longer offered.

Kad's "Connect from known clients" button is not lost: it issued the same
EC_OP_KAD_START the toggle does, exactly as amulegui's ID_KNOWNNODECONNECT
handler is a bare StartKad() call. "Bootstrap from node" is a genuinely
different operation (EC_OP_KAD_BOOTSTRAP_FROM_IP) and is untouched, as is the
per-row connect that dials one specific server.

The page is now a single view file. servers.js, kad.js, ed2k.js and logs.js
were imported by networks.js and nothing else, so splitting them only bought a
five-request, two-wave waterfall behind the lazy route import in app.js
RouteView — the browser had to parse networks.js before it could discover the
other four. At 410 lines the merged file sits alongside preferences.js (411)
and download-detail.js (429), which are single-file multi-tab views already;
Networks was the only page split up. split-detail.js stays separate, being
shared with Downloads and Shared files.

Merging also let some duplication and dead code go:

- stat() was defined identically in kad.js and ed2k.js; one copy remains, and
  the two log panels now share a logBox() helper.
- Three data.ensureStatus() calls in the panels were no-ops. Shell already
  calls it unconditionally for every route (app.js) and it is guarded by
  statusActive, so Ed2kInfoPanel no longer needs an effect at all.
- NetworkConnectButton lives in the view rather than components.js: it is
  Networks-only, and keeping it in components.js would have shipped it
  eagerly to every page.
- app.css: the button is now a .btn, so the tool-btn-derived sizing and the
  dead .tabs-extra .conn-btn overrides are gone. The state colours and
  .tabs-extra itself stay (still used by the Downloads category filters).
- i18n: no new keys — networks_tab_ed2k/_kad and app_connect* already cover
  the label. Eight keys left with no reference are removed, and the missing
  networks_kad_conn_disabled is added; without it the Kad info panel printed
  a raw key string whenever Kad was stopped.

…mule-org#402)

Follow-up review feedback on amule-org#663/amule-org#677's per-tab connect/disconnect
toggle: the button/icon were too large and sat flush against the tab
strip, and since the same button occupies the same spot on both the
ED2K and Kad tabs, its label ("Disconnect") didn't say which network
it affects. Icons are now a uniform 16x16 (down from an inconsistent
32x32/16x16 mix), each row gets a top border, and the label now reads
"Connect ED2K" / "Disconnect Kad" / etc.

Also drops the global Connect/Disconnect toolbar button
(ID_BUTTONCONNECT): it lost its click handler somewhere across
amule-org#663/amule-org#677 and had been dead ever since (no EVT_TOOL binding left) --
the combined both-networks action is still reachable from the tray
icon.

…mule-org#402)

Follow-up review feedback on amule-org#663/amule-org#677's per-tab connect/disconnect
toggle: the button/icon were too large and sat flush against the tab
strip, and since the same button occupies the same spot on both the
ED2K and Kad tabs, its label ("Disconnect") didn't say which network
it affects. Icons are now a uniform 16x16 (down from an inconsistent
32x32/16x16 mix), each row gets a top border, and the label now reads
"Connect ED2K" / "Disconnect Kad" / etc.

Also drops the global Connect/Disconnect toolbar button
(ID_BUTTONCONNECT): it lost its click handler somewhere across
the combined both-networks action is still reachable from the tray
icon.

…mule-org#402)

Follow-up review feedback on amule-org#663/amule-org#677's per-tab connect/disconnect
toggle: the button/icon were too large and sat flush against the tab
strip, and since the same button occupies the same spot on both the
ED2K and Kad tabs, its label ("Disconnect") didn't say which network
it affects. Icons are now a uniform 16x16 (down from an inconsistent
32x32/16x16 mix), each row gets a top border, and the label now reads
"Connect ED2K" / "Disconnect Kad" / etc.

Also drops the global Connect/Disconnect toolbar button
(ID_BUTTONCONNECT): it lost its click handler somewhere across
the combined both-networks action is still reachable from the tray
icon.

Shrinks the per-tab connect button and names its network (Connect/Disconnect/Cancel ED2K|Kad), adds top padding to both network tabs' first row, and scales the button icon to a uniform DPI-aware size with a per-(state, size) cache.

Bitmap margins are wxOSX-only: wxMSW keeps its native font-derived default, wxGTK keeps the leading-space fallback since it has no margin support.

Kad tab redesigned to mirror the ED2K tab: the graph spans the full width with the bootstrap-from-node row beneath it, and the four-octet IP entry collapses to a single trimmed x.x.x.x field.

Drops two redundant controls: the inert global Connect toolbar button (no event binding since #663/#677) and the "Bootstrap from known clients" button, which called the same StartKad() as the Kad tab's own Connect toggle.

This is a deliberate UI change, not a behaviour-preserving refactor --
worth being explicit about per review discussion on #675. None of the
74 sites touched here have ever rendered their border: the legacy
`Add(window, proportion, flag, border)` form only applies `border`
when `flag` carries a direction bit (wxALL/wxLEFT/wxRIGHT/wxTOP/
wxBOTTOM), and all 74 omitted it. Converting to wxSizerFlags() and
supplying a real direction bit means these borders render for the
first time, which will reflow the affected dialogs to some degree.

Per #663 (the case that originally surfaced this pattern): the
recorded border values were never validated by anything, since they
never rendered. Each site was judged against its structural siblings
rather than ported verbatim -- where siblings already carried a
working border, matched to it; where a site was the outlier in an
otherwise-consistent row/grid, adjusted to match rather than
introducing a new, never-tested value. A few sites lost their border
entirely where every sibling in the same row already had none (the
stray value read as leftover noise, not an intended margin).

Three additional non-legacy-syntax inconsistencies folded into the
same pass (found while scoping #675, confirmed still present):
- PreferencesRemoteControlsTab: "Low rights password" carried
  Border(wxLEFT|wxRIGHT, 20) while every other same-column label in
  the grid ("Web template", "Full rights password") uses
  Border(wxRIGHT, 5) -- the 20px left indent looked like it was
  copy-pasted from the unrelated UPnP-port row's indent, not a
  deliberate choice for this row.
- PreferencesOnlineSigTab: the "Save online signature file in" path
  field had no Expand()/proportion despite sitting in a column its
  parent FlexGridSizer marks growable -- it couldn't actually grow to
  fill the space reserved for it.
- PreferencesGeneralTab: the "Browser Selection" row (text field +
  Browse button) still used the legacy 3-arg Add() form while the
  structurally identical "Video Player" row already used
  wxSizerFlags() -- modernized for consistency, no behaviour change
  (both used border 0).

Scope: src/muuli_wdr.cpp only, matching where #663/#473 originally
established (and didn't fully carry through) the wxSizerFlags()
convention.

Testing: full build verified (macOS). Visually walked every dialog
these 20 functions produce that's reachable without live server/
download/client data in a fresh test config: main status bar,
search, transfer panes, shared-files header, servers/Kad tabs,
Friends/Messages panels, and all 15 Preferences tabs -- no clipped or
overlapping controls, and the two directly-testable fixes (the
OnlineSig path field now expanding, the RemoteControls password grid
column now aligned) confirmed visually.

NOT independently verified: fileDetails, clientDetails, commentLstDlg,
and CategoriesEditWindow all require live downloads/shared files/
clients/categories to reach via the UI, which a from-scratch test
config doesn't have -- these got the same siblings-based border
review as everything else, but I have not seen them rendered.
Sizer-border rendering is exactly where wxGTK/wxMSW/wxOSX diverge, so
this needs eyes on Linux and Windows too, per the #675 review
discussion.