fix(packaging/windows): route SPANISHINTERNATIONAL to po/es.po - #64
Merged
got3nks merged 1 commit intoJun 10, 2026
Merged
Conversation
NSIS exposes two Spanish MUI variants -- SPANISH (LCID 0x040a, "Spanish, Traditional Sort") and SPANISHINTERNATIONAL (LCID 0x0c0a, "Spanish, Modern Sort" / Latin America). Modern Windows and Wine both report es_ES as the Modern variant, so the installer's MUI auto-detect routes those users to SPANISHINTERNATIONAL. po-to-nsh.py only mapped "es" -> SPANISH, leaving the SPANISHINTERNATIONAL LangString block at the English fallback. The hand-written ENGLISH baseline in installer.nsi then provided the displayed strings for every es_ES user, defeating the catalog work in 462b2e4. Alias SPANISHINTERNATIONAL onto the same "es" catalog so the generated .nsh produces identical Spanish translations for both NSIS variants. Fixes amule-project#55.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #55. NSIS exposes two Spanish MUI variants —
SPANISH(LCID0x040a, "Spanish, Traditional Sort") andSPANISHINTERNATIONAL(LCID0x0c0a, "Spanish, Modern Sort" / Latin America). Modern Windows and Wine both reportes_ESas the Modern variant, so the installer's MUI auto-detect in installer.nsi routes those users toSPANISHINTERNATIONAL.po-to-nsh.pyonly mapped"es" → SPANISH, leaving theSPANISHINTERNATIONALLangStringblock at the English fallback. The hand-writtenENGLISHbaseline ininstaller.nsithen provided the displayed strings for everyes_ESuser — which is exactly the behaviour @cardpuncher and @ngosang reproduced (French and Turkish work, Spanish doesn't), and which silently neutralised the catalog work in 462b2e4.Fix
One alias added to
NSIS_LANG_TO_LOCALEso the generated.nshemits identical Spanish strings for both NSIS variants:After the fix, the generated
installer_strings_generated.nshcontains a translated${LANG_SPANISHINTERNATIONAL}block byte-equivalent to the${LANG_SPANISH}block (verified locally by re-runningpo-to-nsh.py).Why other locales weren't affected
Each other NSIS language registered in installer.nsi:118-184 maps 1:1 to a single aMule catalog. The other split NSIS pairs (
PORTUGUESE/PORTUGUESEBR,NORWEGIAN/NORWEGIANNYNORSK,SERBIAN/SERBIANLATIN,SIMPCHINESE/TRADCHINESE) are already covered correctly because aMule ships distinct catalogs (pt_PT/pt_BR,nn,zh_CN/zh_TW) for the ones that have translations; the rest fall back to English as intended. Only Spanish has two NSIS variants serviced by a single aMule catalog.Test plan
LANG=es_ES.UTF-8 wine aMule-...-Setup-x64.exeand confirm section names + descriptions are Spanish (reproducing the issue Windows installer is not translated #55 setup).