feat(wizard): offer server-list auto-update on the first-run bootstrap page - #576
Merged
Merged
Conversation
…p page The first-run wizard only downloaded server.met once (when missing); the recurring "Auto-update server list at startup" behaviour (the AutoServerlist pref) defaults off and was reachable only on the Server preferences tab, so a new user's server list never refreshed on its own. Add a checkbox to the Bootstrap page that sets AutoServerlist on Finish, shown whether or not a bootstrap download is offered and checked by default. The label is reused verbatim from the Server tab, so no new translation strings are introduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first-run wizard's Bootstrap page offers a one-time
server.metdownload (only when the file is missing), but the recurring "Auto-update server list at startup" behaviour — theAutoServerlistpreference — defaults off and lives only on the Server preferences tab. So a fresh user bootstraps a server list once and it then never refreshes on its own unless they find that checkbox.This adds the same option to the wizard's Bootstrap page: a checkbox that sets
AutoServerliston Finish. It is shown whether or not a bootstrap download is offered, and checked by default so a first-run user keeps an up-to-date list without hunting for the setting.The label is reused verbatim from the Server tab (
Auto-update server list at startup), so no new translation strings are introduced — the catalogs-in-sync gate strips#:source-reference lines and the msgid is unchanged.Built clean on macOS (monolithic); clang-format and Tier-2 clang-tidy clean.