i18n: remove Italian (Swiss) from the language picker - #561
Merged
Conversation
The it_CH catalog was dropped in amule-project#552, but the language picker is not driven by the shipped catalogs: it iterates the hardcoded aMuleLanguages[] table in Preferences.cpp, which still listed wxLANGUAGE_ITALIAN_SWISS. Removing the catalog could not hide it, because UpdateChoice()'s probe marks an entry available when wxLocale reports PACKAGE loaded, and wxLocale falls back it_CH -> it -- so it.mo kept satisfying the check and the entry stayed visible. Remove the table entry (the picker-side twin of the catalog drop) and drop the now-unused 'Italian (Swiss)' string from the po catalogs. Catalogs edited surgically to keep the diff to the removed entry; the stale source-line references CI already tolerates are left untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
it_CHcatalog was dropped in #552, but the language picker in Preferences → General still showed Italian (Swiss).The picker is not built from the shipped catalogs — it iterates the hardcoded
aMuleLanguages[]table inPreferences.cpp, which still listedwxLANGUAGE_ITALIAN_SWISS. Removing the catalog could not hide it:UpdateChoice()'s probe marks an entry available when wxLocale reportsPACKAGEloaded, and wxLocale falls backit_CH → it, soit.mokept satisfying the check and the entry stayed visible.This removes the table entry (the picker-side twin of the catalog drop) and drops the now-unused
Italian (Swiss)string from the po catalogs.Catalogs were edited surgically so the diff is limited to the removed entry; the stale
#:source-line references (which CI already normalizes away) are left untouched to avoid a whole-tree reflow.