Skip to content

i18n: drop the it_CH (Swiss Italian) catalog - #552

Merged
got3nks merged 1 commit into
amule-org:masterfrom
got3nks:i18n/drop-it-ch
Jul 22, 2026
Merged

i18n: drop the it_CH (Swiss Italian) catalog#552
got3nks merged 1 commit into
amule-org:masterfrom
got3nks:i18n/drop-it-ch

Conversation

@got3nks

@got3nks got3nks commented Jul 22, 2026

Copy link
Copy Markdown

it_CH was not a Swiss-Italian localization but a stale, degraded copy of it: 1531 of 1845 strings (83%) were byte-identical to it, and the divergences were older translator-choice variants (cartelladirectory, collegamentolink, fallitonon riuscito) rather than Helvetisms — plus ~68 unreviewed fuzzy matches and ~140 strings left untranslated that it already covers.

gettext only falls back it_CH → it → C when it_CH.mo is absent, so shipping this catalog gave Swiss-Italian users a worse result than plain Italian (English strings where it is complete). Removing it lets those users fall through to the full, current it catalog.

Also drops the now-dead it_CH wiring: the LINGUAS entry, the po/CMakeLists.txt language label, the redundant [it_CH] .desktop keys (identical to [it]), and the it_CH → ITALIAN mapping in the Windows NSIS generator. it_CH was app-catalog only (no man pages).

it_CH was not a Swiss-Italian localization but a stale, degraded copy of
it: 1531 of 1845 strings (83%) were byte-identical to it, and the
divergences were older translator-choice variants (cartella/directory,
collegamento/link, fallito/non riuscito) rather than Helvetisms, plus
~68 unreviewed fuzzy matches and ~140 strings left untranslated that it
already covers.

gettext only falls back it_CH -> it -> C when it_CH.mo is absent, so
shipping this catalog gave Swiss-Italian users a worse result than plain
Italian (English strings where it is complete). Removing it lets those
users fall through to the full, current it catalog.

Also drops the now-dead it_CH wiring: the LINGUAS entry, the po/
CMakeLists.txt language label, the redundant [it_CH] .desktop keys
(identical to [it]), and the it_CH -> ITALIAN mapping in the Windows
NSIS generator. it_CH was app-catalog only (no man pages).
@got3nks
got3nks merged commit f307fb6 into amule-org:master Jul 22, 2026
11 checks passed
@got3nks
got3nks deleted the i18n/drop-it-ch branch July 22, 2026 18:21
got3nks added a commit that referenced this pull request Jul 22, 2026
The it_CH catalog file was removed in #552, but the surrounding
references were left behind: the LINGUAS entry, the po/CMakeLists.txt
language label, the redundant [it_CH] .desktop keys (identical to
[it]), and the it_CH -> ITALIAN mapping in the Windows NSIS generator.

None affect the build (it is glob-driven and it_CH.po is already gone),
but they point at a catalog that no longer exists. Remove them so the
tree is consistent.
got3nks added a commit that referenced this pull request Jul 23, 2026
The it_CH catalog was dropped in #552, but the language picker is not
driven by the shipped catalogs: it iterates the hardcoded
aMuleLanguages[] table in Preferences.cpp, which still listed
wxLANGUAGE_ITALIAN_SWISS. Removing the catalog could not hide it,
because UpdateChoice()'s probe marks an entry available when wxLocale
reports PACKAGE loaded, and wxLocale falls back it_CH -> it -- so it.mo
kept satisfying the check and the entry stayed visible.

Remove the table entry (the picker-side twin of the catalog drop) and
drop the now-unused 'Italian (Swiss)' string from the po catalogs.
Catalogs edited surgically to keep the diff to the removed entry; the
stale source-line references CI already tolerates are left untouched.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant