build: disable BUILD_TESTING by default - #49
Merged
Conversation
Most users do not need to compile the unit tests; the previous default of ON added unnecessary compile time. Anyone developing or running the test suite can re-enable it with -DBUILD_TESTING=ON. Also corrects the option description from "Run Tests after compile" (misleading — tests are compiled but not executed by the build) to "Build unit tests". Closes amule-project#46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BUILD_TESTINGdefault fromONtoOFFincmake/options.cmakeWhy no CI changes needed
The CI workflow (
.github/workflows/ccpp.yml) already passes-DBUILD_TESTING=YESexplicitly incmake_common_config_flags. This flag is unaffected by the default — the CI has always been self-contained in this regard. No workflow file needed to change.Test plan
unittests/is not built-DBUILD_TESTING=ON: verify tests build andctestpassesCloses #46