fix Global search when Kad is disabled - #38
Merged
Conversation
|
Thanks @danim7 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Global search not working if Kad is disabled
Steps to reproduce:
Fix: Remove the wrong selection += 1 when Kad is disabled, which is just wrong. Also, add a comment explaining why do we modify the selection index.
Tests:
Tested the 4 combinations, all work as expected now:
Kad Enabled + ED2K Enabled
Kad Enabled + ED2K Disabled
Kad Disabled + ED2K Enabled
Kad Disabled + ED2K Disabled