feat(webui): replace language toggle with scalable dropdown - #304
Merged
Conversation
The navbar language selector was a cycle button that stepped through languages one click at a time, which does not scale beyond a couple of locales. Replace it with a native <select> dropdown that lists every language and works identically on desktop and mobile. - app.js: LangButton (cycle button) -> LangSelect, a native <select> populated from LANGS; selecting an option calls setLang() to persist and reload. Rendered in both the desktop tools and the mobile drawer. - i18n.js: drop the obsolete cycleLang(); add langName() to show each language as its own autonym via Intl.DisplayNames (no data to maintain). - app.css: style .lang-select to blend into the ghost toolbar and make it a full-width 44px row in the mobile drawer. Accessibility is covered by the select's aria-label plus the label title.
Cflsft
pushed a commit
to Cflsft/amule
that referenced
this pull request
Jul 6, 2026
…g#304) The navbar language selector was a cycle button that stepped through languages one click at a time, which does not scale beyond a couple of locales. Replace it with a native <select> dropdown that lists every language and works identically on desktop and mobile. - app.js: LangButton (cycle button) -> LangSelect, a native <select> populated from LANGS; selecting an option calls setLang() to persist and reload. Rendered in both the desktop tools and the mobile drawer. - i18n.js: drop the obsolete cycleLang(); add langName() to show each language as its own autonym via Intl.DisplayNames (no data to maintain). - app.css: style .lang-select to blend into the ghost toolbar and make it a full-width 44px row in the mobile drawer. Accessibility is covered by the select's aria-label plus the label title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The navbar language selector was a cycle button that stepped through languages one click at a time. This does not scale beyond a couple of locales, so replace it with a native dropdown that lists every language and works identically on desktop and mobile. app.js: LangButton (cycle button) -> LangSelect, a native
populated from LANGS; selecting an option calls setLang() which
persists and reloads. Rendered in both the desktop tools and the
mobile drawer.