fix(webserver): avoid form resubmission prompt on auto-refresh - #230
Merged
Conversation
The auto-refresh introduced in 2effbb2 used location.reload(), which repeats the original request. On pages whose forms POST (e.g. filtering downloads by category), each timed reload resubmitted the POST data, triggering the browser's "confirm form resubmission" dialog and breaking the page. Replace location.reload() with window.location.href = window.location.href so the auto-refresh performs a plain GET navigation, matching the old <meta refresh> behavior. Filter/sort state is preserved because it is stored in $_SESSION. Applied uniformly to dload, kad, search, servers, shared and stats pages in the default template.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #226
The auto-refresh introduced in 2effbb2 used location.reload(), which repeats the original request. On pages whose forms POST (e.g. filtering downloads by category), each timed reload resubmitted the POST data, triggering the browser's "confirm form resubmission" dialog and breaking the page.
Replace location.reload() with window.location.href = window.location.href so the auto-refresh performs a plain GET navigation, matching the old behavior. Filter/sort state is preserved because it is stored in $_SESSION. Applied uniformly to dload, kad, search, servers, shared and stats pages in the default template.