feat(webserver): unify file size and speed units in default template - #218
Merged
Conversation
The download, shared and search pages each defined their own CastToXBytes function with inconsistent units (kb/KB, mb/MB, " b"/" bytes") and no decimal rounding, so the same value looked different across pages. Unit formatting is now done client-side in JavaScript: CastToXBytes emits the raw byte count inside a <span class="js-size"> and a shared formatBytes() script at the end of each page renders consistent, human-readable units (Bytes / KB / MB / GB, 1024 divisor, 2 decimals; speed keeps the trailing "/s"). This is required because the webserver's embedded PHP interpreter lacks sprintf/round/number_format, which made server-side formatting impossible. The download totals still accumulate raw bytes via the &$count parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The download, shared and search pages each defined their own CastToXBytes function with inconsistent units (kb/KB, mb/MB, " b"/" bytes") and no decimal rounding, so the same value looked different across pages.
Unit formatting is now done client-side in JavaScript: CastToXBytes emits the raw byte count inside a and a shared formatBytes() script at the end of each page renders consistent, human-readable units (Bytes / KB / MB / GB, 1024 divisor, 2 decimals; speed keeps the trailing "/s"). This is required because the webserver's embedded PHP interpreter lacks sprintf/round/number_format, which made server-side formatting impossible. The download totals still accumulate raw bytes via the &$count parameter.