feat(webserver): improve search page controls in default template - #215
Merged
Conversation
Rework the user-facing controls on the search page: - Move the Download button and target-category selector above the results table so they stay reachable with many results, and add a spacer row separating them from the table header. - Rename the download target-category 'all' label from 'All categories' to 'No category'. - Replace the 'Click here to update the search results' text link with an 'Update results' button matching the native style of the Download button. - Simplify sort handling to a single 'sort' query param: column headers use ?sort=<key> and toggle direction, while 'Update results' just reloads the page and the current order is preserved via the session without flipping. Drops the redundant 'search_sort' param. The sort key stays whitelisted against the keys my_cmp() understands (amule-project#869).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework the user-facing controls on the search page: