Skip to content

feat(webserver): confirm download/delete with file count in default template - #214

Merged
ngosang merged 1 commit into
amule-org:masterfrom
ngosang:feature/issues14
Jun 20, 2026
Merged

feat(webserver): confirm download/delete with file count in default template#214
ngosang merged 1 commit into
amule-org:masterfrom
ngosang:feature/issues14

Conversation

@ngosang

@ngosang ngosang commented Jun 20, 2026

Copy link
Copy Markdown
Member

Show the number of selected files in the confirmation dialogs and avoid acting when nothing is selected, in the default web template.

  • Search: extend formCommandSubmit's "download" path to count selected checkboxes (excluding the select-all master), return early when none are selected, and confirm "Download selected N files ?".
  • Search: add "return false" to the Download submit button onClick so the native form submission no longer fires; formCommandSubmit submits the form itself. This fixes the page reloading even when the user pressed Cancel in the confirmation dialog.
  • Downloads: replace the generic "Delete selected files ?" prompt with a count-aware "Delete selected N files ?", returning early when no rows are selected.

…emplate

Show the number of selected files in the confirmation dialogs and avoid
acting when nothing is selected, in the default web template.

- Search: extend formCommandSubmit's "download" path to count selected
  checkboxes (excluding the select-all master), return early when none
  are selected, and confirm "Download selected N files ?".
- Search: add "return false" to the Download submit button onClick so the
  native form submission no longer fires; formCommandSubmit submits the
  form itself. This fixes the page reloading even when the user pressed
  Cancel in the confirmation dialog.
- Downloads: replace the generic "Delete selected files ?" prompt with a
  count-aware "Delete selected N files ?", returning early when no rows
  are selected.
@ngosang
ngosang merged commit 113f7db into amule-org:master Jun 20, 2026
9 checks passed
@ngosang
ngosang deleted the feature/issues14 branch June 20, 2026 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant