feat(webserver): confirm download/delete with file count in default template - #214
Merged
Merged
Conversation
…emplate Show the number of selected files in the confirmation dialogs and avoid acting when nothing is selected, in the default web template. - Search: extend formCommandSubmit's "download" path to count selected checkboxes (excluding the select-all master), return early when none are selected, and confirm "Download selected N files ?". - Search: add "return false" to the Download submit button onClick so the native form submission no longer fires; formCommandSubmit submits the form itself. This fixes the page reloading even when the user pressed Cancel in the confirmation dialog. - Downloads: replace the generic "Delete selected files ?" prompt with a count-aware "Delete selected N files ?", returning early when no rows are selected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show the number of selected files in the confirmation dialogs and avoid acting when nothing is selected, in the default web template.