fix(webserver): correct default template layout glitches after HTML5 switch - #204
Merged
Merged
Conversation
…switch The HTML5 doctype upgrade (standards mode) introduced inline-image descender gaps that were fixed for some images but missed two, and exposed a pre-existing layout inconsistency on the shared page: - Login page: give the logo image display:block so its descender gap no longer makes the banner row taller than its background, which left a thin white line below the login box. Add a login-logo class to scope the rule. - Navbar: give the col.png separator (the only inline <img> in the navbar) display:block, removing the ~2px descender gap that made the bar taller and pushed all page content down by 2px. - Shared page: add the 10px spacer between the action toolbar and the content box that the downloads page already has, so both toolbar pages share the same header-to-content separation. - Login page: make the "Enter password" label black instead of the inherited dark blue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTML5 doctype upgrade (standards mode) introduced inline-image descender gaps that were fixed for some images but missed two, and exposed a pre-existing layout inconsistency on the shared page: