search: correct miscategorised file extensions and add modern formats - #189
Merged
got3nks merged 1 commit intoJun 17, 2026
Merged
Conversation
…rmats Refs amule-project#842. Part 1 — corrections (5): - .m4b: Video → Audio (MPEG-4 audiobook, M4A audio with chapters) - .msi: Archive → Program (Windows Installer package, not a generic archive) - .xpi: Archive → Program (Mozilla browser extension package) - .dmz: removed (no known disc-image format; only known as obsolete DMesh 3D-model — likely a stray entry from eMule) - Source-comment fixes for .mp1v / .mp4 / .mpe (MPEG version mix-up) and .sub (CloneCD subchannel data, not subtitle). Part 2 — additions (~95): - Audio: opus, oga, weba, wv, dsf, dff, caf, aa, aax - Video: mts, f4v, mxf, h264, h265, hevc - Pictures: heic, heif, avif, jxl, svg, jp2, j2k, xcf, apng, dng, cr2, cr3, nef, arw, orf, raf, rw2 - Archives: zst, xz, txz, lz4, lzma, lz, tlz, cb7, cba - Programs: ps1, psm1, psd1, sh, app, appx, msix, appimage, flatpak, snap, scr, cpl, deb, rpm, apk, jar - CD-Images: vhd, vhdx, vmdk, vdi, qcow2, wim, mdx, daa, isz, uif, cdi, b5t, b6t, vcd - Texts: docx/docm/dotx, xlsx/xlsm/xltx, pptx/pptm/potx/ppsx (OOXML full set), md, markdown, csv, json, yaml, yml, tex, djvu, xps, oxps, fb2, azw3, kfx, pages, numbers, key Guiding principle for software packages (per the issue): general- purpose compressed containers stay under Archives; extensions whose purpose is to package or deliver software belong under Programs even when internally zip-based. Note: Archive and CD-Image categories are server-side mapped to "Pro" (Program) by GetED2KFileTypeSearchTerm, so additions to those two categories affect aMule's local filtering only — no server-query behaviour change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs amule-project/amule#842 (legacy repo).
The file-type filter in the search window (
Any / Archives / Audio / CD-Images / Pictures / Programs / Texts / Videos) maps each category to a list of file extensions insrc/OtherFunctions.cpp(CED2KFileTypesconstructor). This list dates from the eMule era and had two issues: a handful of misclassified extensions, and a lot of formats that have become mainstream since ~2010 that were missing — so files with those extensions weren't matched by the corresponding filter and the file-type heuristic returned no type for them elsewhere either.Part 1 — corrections
.mp1v("QuickTime Movie File" → MPEG-1),.mp4("MPEG-2 Video File" → MPEG-4),.mpe("MPEG-4 Video File" → MPEG-1),.sub("Subtitle File" → CloneCD subchannel data file — its.ccd/.img/.subset is correctly categorised as CD-Image).Part 2 — additions
~95 extensions added across the seven categories. Highlights: Opus / OGA / WebA / WavPack / DSD / Audible (audio); MTS / F4V / MXF / H.264 / H.265 / HEVC (video); HEIC / HEIF / AVIF / JXL / SVG / JPEG 2000 / GIMP / animated PNG / camera-RAW set (pictures); Zstandard / XZ / LZ4 / LZMA / Lzip / comic-book 7z+ACE (archives); PowerShell scripts / shell scripts / app bundles / Win App Package / AppImage / Flatpak / Snap / .deb / .rpm / .apk / .jar (programs); virtual-disk images (VHD/VHDX/VMDK/VDI/qcow2/WIM) and modern disc-image set (CD-Images); the full OOXML set (docx/docm/dotx, xlsx/xlsm/xltx, pptx/pptm/potx/ppsx), Markdown, CSV, JSON, YAML, LaTeX, DjVu, XPS, FictionBook, modern Kindle (azw3/kfx), Apple iWork (pages/numbers/key) (texts).
Notes
Archive vs. Program —
Archivesis for general-purpose compressed file containers; an extension whose purpose is to package, deliver, or run software belongs inPrograms, even when internally a zip / compressed container. The moves above and all new software-package additions follow this rule.Server-side search —
GetED2KFileTypeSearchTerm()(src/OtherFunctions.cpp:976) already mapsED2KFT_ARCHIVEandED2KFT_CDIMAGEtoED2KFTSTR_PROGRAM("Pro") for server queries — the inline comment on line 983 acknowledges this. Adding extensions to Archive and CD-Image therefore changes aMule's local filtering only; server-side query behaviour is unchanged.Test plan