fix(webserver): PR #150 follow-up - #155
Merged
Merged
Conversation
…ing termination in CWriteStrBuffer::Write of php_core_lib
got3nks
requested changes
Jun 14, 2026
got3nks
left a comment
got3nks
left a comment
There was a problem hiding this comment.
CI is red because s[len] = '\0'; writes through const char *s (the input parameter). Should be m_buf_ptr[len] = '\0'; — write the null to the destination, not the source. Place it before the m_buf_ptr += len; advance, or equivalently use *m_buf_ptr = '\0'; after.
The cast_value_dnum(result) removal in php_native_htmlspecialchars is fine.
Author
|
Sorry for mistake, fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #150