fix(webserver): php_syntree various fixes - #153
Merged
Conversation
got3nks
approved these changes
Jun 14, 2026
got3nks
left a comment
got3nks
left a comment
There was a problem hiding this comment.
Thanks. Both fixes verified:
PRIu64→PRId64at line 965 — picks up exactly the inconsistency I flagged in #150's review. The codebase is now consistent in displayingint_valas signed across bothphp_var_dumpandcast_value_str.- Missing
breakincast_value_arraySTRING case — real fall-through bug.case PHP_VAL_STRING: free(val->str_val);was falling intocase PHP_VAL_ARRAY: return;, so callingcast_value_arrayon aPHP_VAL_STRINGfreed the string buffer and exited without allocating the array — callers post-cast would touch uninitialised memory. The addedbreak;lets execution reach the allocation at lines 993-994.
Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
breakfortype == PHP_VAL_STRINGincast_value_array()— without it, the function exits at thePHP_VAL_ARRAYbranch before actually allocating the array.PRIu64withPRId64incast_value_str()—PHP_VAL_INTholds a signed integer.