fix(webserver): php_amule_lib_standalone various fixes - #151
Merged
got3nks merged 3 commits intoJun 14, 2026
Conversation
…p_amule_lib_standalone
…native_search_download_cmd and php_native_ed2k_download_cmd functions of php_amule_lib_standalone
RealGreenDragon
changed the title
got3nks
approved these changes
Jun 14, 2026
got3nks
left a comment
got3nks
left a comment
There was a problem hiding this comment.
Thanks. Verified:
#include <map>duplication confirmed at lines 31 + 38.printfcopy-paste bug — clear fix.- String-check removal matches
php_native_server_cmdpattern; the subsequentcast_value_dnumhandles type conversion correctly.
On the doubt: yes, php_native_search_start_cmd argument 4 (search type) being parsed but unused is a real loose end. Suggested addition is reasonable. Would prefer it in a separate PR though — keep this one tight on the three fixes you've listed. Open a follow-up and link it here?
Approving.
got3nks
added a commit
that referenced
this pull request
Jun 14, 2026
fix(webserver): PR #151 follow-up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
printfinphp_native_ed2k_download_cmdfunction (copy-paste issue)php_native_search_download_cmdandphp_native_ed2k_download_cmdfunctions (useless as the value is cast to int, so an int parameter value can be accepted, as happens in other functions such asphp_native_server_cmd)#include <map>Doubts and Suggestions
php_native_search_start_cmdargument 4 (search type) is parsed but not assigned to any variable → addint search_type = si->var->value.int_val;and replacetype=%swithfile_type=%s\nsearch_type=%dinprintfIf you can help me clarify the doubts, I will apply the suggested changes in this PR.