fix(search): move Directories column to the end - #142
Merged
Conversation
danim7 in amule-project#136: the Directories column is almost always empty in practice — it's only populated when a result came from a "view shared files" request against another peer, which is rare on today's network. Sitting between Status and the (often-empty) Length / Bitrate / Codec columns it adds a wide visual gap to the typical layout. Move it to the very end so all the rarely-populated columns cluster on the right edge of the list. Column persistence keys are name-based (N, Z, u, Y, I, S, L, B, C, D), so existing users' saved widths and visibility for Directories transfer cleanly to the new position.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #139 / #136. @danim7 noted that the Directories column is almost always empty (only populated when a result came from a "view shared files" request against another peer, which is rare on today's network). Sitting between Status and the also-usually-empty Length / Bitrate / Codec columns it adds a wide visual gap to the typical layout.
Fix
Move Directories to the very end of the column order so all the rarely-populated columns cluster on the right edge.
Column persistence is name-based — keys are
N,Z,u,Y,I,S,L,B,C,D— so existing users' saved widths and visibility for Directories transfer cleanly to the new position. No migration shim needed.Test plan