fix(prefs/macos): pad tab icons in left rail - #130
Merged
Conversation
wxOSX NSTableView draws the row image flush against the cell label, giving the Preferences left-rail tab icons no visible breathing room. wxGTK and wxMSW each insert a few pixels of native padding between the image and the text in wxLC_REPORT mode. Widen the image list from 16x16 to 24x16 and right-pad each source bitmap with 8 transparent pixels via wxImage::Size before adding to the list. The extra transparent column is invisible on wxGTK/wxMSW (row background bleeds through) so the change is platform-uniform without an #ifdef.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wxOSX NSTableView draws the Preferences left-rail icons flush against the cell label and bottom-anchored to the row, producing a cramped look on Mac. wxGTK / wxMSW already pad these natively, so no Linux/Windows change is wanted.
Fix
#ifdef __WXOSX__-gated padding around the 16×16 tab-icon source bitmaps inPrefsUnifiedDlg::TransferToWindow():The wxImageList width / height grow accordingly. On wxGTK / wxMSW the
#ifdefselects pad values of 0, thepadIconlambda short-circuits to a no-opreturn src, and the image list stays at the original 16×16 — so the change is mechanically a no-op outside Mac.Test plan
amulerebuilt cleanly on amule-dev-vm, Preferences left rail visually unchanged from master.