feat(shared): default "Show Clients for" to "All files" - #126
Merged
Conversation
Previously the radio defaulted to ClientShowSelected, which requires the user to first click on a shared file before any client/peer rows appear -- confusing for first-time users who land on the Shared Files tab and see an empty list with no obvious reason why. Flip the fallback at SharedFilesWnd.cpp:76 to ClientShowAll so the peer table populates with all known clients on first open. Behaviour for existing users is unchanged: anyone who has opened the Shared Files tab before has the explicit selection persisted in `/GUI/SharedWnd/ClientShowMode`, so `config->Read` returns their saved value instead of the new fallback. The change lives in core (non-CLIENT_GUI-gated) code shared between the monolithic `amule` and `amulegui` builds, so both pick it up. Closes amule-project#114.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #114. The "Show Clients for" radio on the Shared Files tab defaulted to
ClientShowSelected, which only populates the peer table once the user clicks on a specific file. First-time users land on the tab, see an empty list, and have no obvious cue that selecting a file is required. Flipping the default toClientShowAllmakes the tab self-explanatory.Change
One line in
CSharedFilesWnd::CSharedFilesWnd:The change is in core code shared between the monolithic
amuleandamuleguibuilds (the surrounding#ifdef CLIENT_GUIblocks are at lines 197 and 214; this line is outside both), so both targets pick up the new default.Behaviour for existing users
Unchanged. Anyone who has previously opened the Shared Files tab has the explicit selection persisted in
~/.aMule/amule.confunder[GUI/SharedWnd]→ClientShowMode=…, sowxConfigBase::Readreturns their saved value rather than the new fallback. Only fresh installs and users who've never opened that tab see the changed default.Test plan
amuleandamulegui(cmake --build build-macos --target amule amulegui).~/.aMule/→ open Shared Files tab → "All files" pre-selected, peer list populated immediately.