chore: add active-home ISSUE_TEMPLATE/config.yml and pull_request_template.md - #12
Merged
Merged
Conversation
…plate.md Templates for the active development home — keep blank issues enabled and add a Discussions contact link for question-style content; minimal PR scaffold with Summary + Test plan headers. Once merged, these override any future "Sync fork" pass from amule-project (which carries the "issues moved to amule-org" redirect text on the same paths) and mark the intentional divergence between the two repos on .github/.
13 tasks
got3nks
added a commit
that referenced
this pull request
Jun 14, 2026
…atforms
The macOS-only `std::_Exit(0)` block in OnExit() was added to dodge a
wxWebSessionURLSession dtor bug under wx 3.3.2. Turns out the
Linux backend (wxWebSessionCURL, wx 3.2.6) hits the same class of
shutdown crash: its dtor calls curl_multi_cleanup, libcurl invokes the
registered socket callback (wxWebSessionCURL::SocketCallback) to drop
tracked sockets, and that callback dereferences session state the
dtor's earlier steps have already torn down. wxASSERT fires,
wxFatalSignalHandler raise(SIGABRT)s.
Verified with a debug-symbol Flatpak + gdb on a user-supplied core,
fully symbolicated:
#19 main amule-gui.cpp:98
#18 wxEntry wx/init.cpp:500
#17 wxEntryCleanup wx/init.cpp:205
#16 wxModule::CleanUpModules wx/module.cpp:191
#15 wxModule::DoCleanUpModules wx/module.cpp:200
#14 wxRefCounterMT::DecRef
wxWebSession::Close wx/webrequest.cpp:1074
#13 wxWebSessionCURL::~wxWebSessionCURL wx/webrequest_curl.cpp:932
#12 wxWebSessionCURL::~wxWebSessionCURL wx/webrequest_curl.cpp:929
#11-#6 libcurl curl_multi_cleanup
#5 wxWebSessionCURL::SocketCallback wx/webrequest_curl.cpp:1047
#4 raise()
#3 wxFatalSignalHandler wx/unix/utilsunx.cpp:1523
#0 abort
Same justification used for the macOS guard applies on every
platform: by this point in OnExit we have saved state, joined
threads, and flushed logs -- nothing aMule-owned remains to clean up.
_Exit bypasses atexit and static destructors uniformly, so the buggy
wx dtor never runs and the process terminates cleanly.
Remove this once the upstream wx fix lands in a release we depend on.
Reported in #18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds amule-org/amule's own
.github/ISSUE_TEMPLATE/config.ymland.github/pull_request_template.mdso that when amule-project#921 lands its mirror-redirect versions of the same paths, a future "Sync fork" pass into this repo doesn't propagate the "issues moved to amule-org" notice onto the active home (where it would be self-referential).config.yml: keeps blank issues enabled, adds a Discussions contact link as a soft funnel for question-style content (Discussions are already enabled on this repo).pull_request_template.md: minimal contributor scaffold — Summary + Test plan headers, no mirror notice.Divergence point
Once this PR is merged, amule-org/amule and amule-project/amule lose sync on
.github/. From here on:.github/(via chore: restore mirror-redirect static config (held for post-3.0.0) amule-project/amule#921) will send issue / PR openers to this repo.No further "Sync fork" passes from amule-project should be needed; both repos are intentionally divergent on
.github/going forward, and code changes flowamule-org → amule-project(not the other way) if a mirror update is wanted at all.Refs